From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hdegoede@redhat.com, adrienverge@gmail.com, yaowen@google.com,
vpalatin@chromium.org, stern@rowland.harvard.edu,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan
Date: Wed, 6 Jul 2016 21:05:40 -0400 [thread overview]
Message-ID: <577DAAE4.4060600@canonical.com> (raw)
In-Reply-To: <20160707010248.GA20126@kroah.com>
On 07/06/2016 09:02 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power
>> Management so adding a quirk. This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> Cc: stable <stable@vger.kernel.org>
>> ---
>> drivers/usb/core/quirks.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..f028cc5 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
>>
>> { USB_DEVICE(0x04f3, 0x016f), .driver_info =
>> USB_QUIRK_DEVICE_QUALIFIER },
>> +
>> + { USB_DEVICE(0x04f3, 0x0381), .driver_info =
>> + USB_QUIRK_NO_LPM },
>>
>> { USB_DEVICE(0x04f3, 0x21b8), .driver_info =
>> USB_QUIRK_DEVICE_QUALIFIER },
>> -
>> +
> This is odd, why remove and add a blank line for no reason?
>
That is odd and wasn't intentional, I'll send a V3.
prev parent reply other threads:[~2016-07-07 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 0:58 [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Joseph Salisbury
2016-07-07 1:02 ` Greg KH
2016-07-07 1:05 ` Joseph Salisbury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577DAAE4.4060600@canonical.com \
--to=joseph.salisbury@canonical.com \
--cc=adrienverge@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vpalatin@chromium.org \
--cc=yaowen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox