From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Reply-To: xlpang@redhat.com
Subject: Re: [PATCH] sched/fair: do not announce throttled next buddy in
 dequeue_task_fair
References: <146608183552.21905.15924473394414832071.stgit@buzz>
 <CANRm+Cxo1q-GyWcSQfZ3S=FAL8opCi0uH=NVJcEFiLyf8dCbVQ@mail.gmail.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org
From: Xunlei Pang <xpang@redhat.com>
Message-ID: <57835735.6020906@redhat.com>
Date: Mon, 11 Jul 2016 16:22:13 +0800
MIME-Version: 1.0
In-Reply-To: <CANRm+Cxo1q-GyWcSQfZ3S=FAL8opCi0uH=NVJcEFiLyf8dCbVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 2016/07/11 at 15:25, Wanpeng Li wrote:
> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov <khlebnikov@yandex-team.ru>:
>> Hierarchy could be already throttled at this point. Throttled next
>> buddy could trigger null pointer dereference in pick_next_task_fair().
> There is cfs_rq->next check in pick_next_entity(), so how can null
> pointer dereference happen?

I guess it's the following code leading to a NULL se returned:
pick_next_entity():
    if (cfs_rq->next && wakeup_preempt_entity(cfs_rq->next, left) < 1)
        se = cfs_rq->next;

Regards,
Xunlei

> Regards,
> Wanpeng Li