From: Richard Weinberger <richard@nod.at>
To: Rajeev Kumar <rajeev_kumar@mentor.com>,
dwmw2@infradead.org, computersforpeace@gmail.com
Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] MTD: UBI: speed up init by moving status messages to debugfs
Date: Mon, 25 Jul 2016 12:31:45 +0200 [thread overview]
Message-ID: <5795EA91.2030304@nod.at> (raw)
In-Reply-To: <1469440019-29358-1-git-send-email-rajeev_kumar@mentor.com>
Rajeev,
Am 25.07.2016 um 11:46 schrieb Rajeev Kumar:
> This patch simply moves the verbose status messages associated with
> UBI's fastmap feature to debugfs, thereby decreasing UBI
> initialization time from 97 mS to 16 mS. Note that the first time
> fastmap is invoked, building the fastmap took 146 mS. In order to
> reproduce the test conditions, build with CONFIG_MTD_UBI_FASTMAP=y and
> CONFIG_DYNAMIC_DEBUG=y and append the following to bootargs:
>
> initcall_debug ubi.mtd=0 ubi.fm_autoconvert=1
>
> ubi.mtd=0 is needed at every boot if you want ubi to be
> autoloaded. ubi.fm_autoconvert switch is needed only once, when
> fastmap is created.
So, you're working on a system which has to boot as fast as possible
and writing kernel logs hurts the performance. (Slow UART?)
Why do you change logging only in UBI (Fastmap)? Many other subsystems
print during boot and would also hurt the performance.
In such a situation I'd assume that changing the kernel log level or
using the quiet kernel parameter would help more.
Thanks,
//richard
next prev parent reply other threads:[~2016-07-25 10:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 9:46 [PATCH 1/2] MTD: UBI: speed up init by moving status messages to debugfs Rajeev Kumar
2016-07-25 9:46 ` [PATCH 2/2] ubi: attach: do not return -EINVAL if the mtd->numeraseregions is 1 Rajeev Kumar
2016-07-25 10:31 ` Richard Weinberger
2016-07-25 11:16 ` Rajeev Kumar
2016-07-25 11:20 ` Richard Weinberger
2016-07-29 18:24 ` Brian Norris
2016-08-04 6:30 ` Artem Bityutskiy
2016-09-23 11:20 ` Chugh, Sanjeev
2016-09-23 11:37 ` Chugh, Sanjeev
2016-10-26 12:26 ` Chugh, Sanjeev
2016-07-25 10:31 ` Richard Weinberger [this message]
2016-07-25 11:23 ` [PATCH 1/2] MTD: UBI: speed up init by moving status messages to debugfs Rajeev Kumar
2016-07-25 11:32 ` Richard Weinberger
2016-07-25 16:47 ` Greg KH
2016-07-25 20:39 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5795EA91.2030304@nod.at \
--to=richard@nod.at \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rajeev_kumar@mentor.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).