From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from aserp1040.oracle.com ([141.146.126.69]:48703 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753038AbcHQTwZ (ORCPT
	<rfc822;stable@vger.kernel.org>); Wed, 17 Aug 2016 15:52:25 -0400
Subject: Re: [PATCH 2/2] pipe: make pipe user buffer limit checks more precise
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
References: <86c85cff-7fee-cded-386a-e1d518573dda@gmail.com>
 <db82480c-7956-b89d-1f4e-ba2c94f4067e@gmail.com>
 <57B301FE.9090108@oracle.com>
 <1532b6c4-c618-348c-d36a-9679d5d5a1b4@gmail.com>
 <57B38CF7.5080803@oracle.com>
 <67c8abf7-df7c-444d-7876-d160a211c969@gmail.com>
 <57B4BC5B.9050405@oracle.com>
 <55f54f95-f614-179e-db4b-912adf2199bb@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>, socketpair@gmail.com,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Jens Axboe <axboe@fb.com>, Al Viro <viro@zeniv.linux.org.uk>,
	stable@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org
From: Vegard Nossum <vegard.nossum@oracle.com>
Message-ID: <57B4C051.7030200@oracle.com>
Date: Wed, 17 Aug 2016 21:51:45 +0200
MIME-Version: 1.0
In-Reply-To: <55f54f95-f614-179e-db4b-912adf2199bb@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 08/17/2016 09:41 PM, Michael Kerrisk (man-pages) wrote:
>>> So, would that mean something like the following (where I've moved
>>> some checks from pipe_fcntl() to pipe_set_size()):
>> [...]
>
> And, do you agree that something similar is required for alloc_pipe_info()
> when creating a pipe?

Yeah, that sounds correct to me.


Vegard