From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:47774 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbcIIPmk (ORCPT ); Fri, 9 Sep 2016 11:42:40 -0400 Subject: Re: [PATCH v2] irqchip/gic: Allow self-SGIs for SMP on UP configurations To: Fabio Estevam References: <1473428682-14552-1-git-send-email-festevam@gmail.com> <57D2C9F1.5070900@arm.com> Cc: stable , Fabio Estevam From: Marc Zyngier Message-ID: <57D2D868.7090205@arm.com> Date: Fri, 9 Sep 2016 16:42:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 09/09/16 16:31, Fabio Estevam wrote: > Hi Marc, > > On Fri, Sep 9, 2016 at 11:40 AM, Marc Zyngier wrote: >> Hi Fabio, >> >> On 09/09/16 14:44, Fabio Estevam wrote: >>> From: Marc Zyngier >>> >>> commit 059e232089e45b0befc9933d31209c225e08b426 upstream. >>> >>> On systems where a single CPU is present, the GIC may not support >>> having SGIs delivered to a target list. In that case, we use the >>> self-SGI mechanism to allow the interrupt to be delivered locally. >>> >>> Cc: # 4.7.x >>> Tested-by: Fabio Estevam >>> Signed-off-by: Marc Zyngier >>> Signed-off-by: Fabio Estevam >> >> I'm sorry, but what is the justification for this to be backported to a >> stable kernel? It is not a regression, since we never supported this > > Without this patch imx6ul SoC hangs after a 'reboot' command. But that's not a regression, right? It *never* worked before, as far as I know, because we never supported such a configuration in the past. I'm a bit concerned when I see backporting random patches to random kernel versions for things that are not bugs. I'll leave it up to Greg to decide, but I thought I should point out what this patch actually is. Thanks, M. -- Jazz is not dead. It just smells funny...