From: Marc Zyngier <marc.zyngier@arm.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: stable <stable@vger.kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2] irqchip/gic: Allow self-SGIs for SMP on UP configurations
Date: Fri, 9 Sep 2016 17:06:02 +0100 [thread overview]
Message-ID: <57D2DDEA.4050505@arm.com> (raw)
In-Reply-To: <CAOMZO5BAW0RgZe4w4bMEL8pvxZ8epesqPJRaujLxigphd6Nz4w@mail.gmail.com>
On 09/09/16 16:48, Fabio Estevam wrote:
> Hi Marc,
>
> On Fri, Sep 9, 2016 at 12:42 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>
>>> Without this patch imx6ul SoC hangs after a 'reboot' command.
>>
>> But that's not a regression, right? It *never* worked before, as far as
>> I know, because we never supported such a configuration in the past.
>
> imx6ul is supported since kernel 4.3.
And yet nobody reported this as an issue until the 4.8 cycle. So it
doesn't look like it was annoying anyone until then.
>
>> I'm a bit concerned when I see backporting random patches to random
>> kernel versions for things that are not bugs. I'll leave it up to Greg
>> to decide, but I thought I should point out what this patch actually is.
>
> Not bugs? I consider the hang I get after running 'reboot' on imx6ul a bug.
>
> According to Documentation/stable_kernel_rules.txt :
>
> " - It must fix a problem that causes a build error (but not for things
> marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
> security issue, or some "oh, that's not good" issue. In short, something
> critical. "
>
> , so that's why I submitted for stable inclusion.
>
I don't, which is why I didn't tag it for stable the first place. I
consider this as an unsupported configuration (MP CPU on a UP GIC),
which we start supporting from 4.8 onward.
Anyway, I'm not going to argue any further for such a small patch, but
I've made my position clear.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-09-09 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 13:44 [PATCH v2] irqchip/gic: Allow self-SGIs for SMP on UP configurations Fabio Estevam
2016-09-09 14:40 ` Marc Zyngier
2016-09-09 15:31 ` Fabio Estevam
2016-09-09 15:42 ` Marc Zyngier
2016-09-09 15:48 ` Fabio Estevam
2016-09-09 16:06 ` Marc Zyngier [this message]
2016-09-09 16:12 ` Greg KH
2016-09-09 16:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D2DDEA.4050505@arm.com \
--to=marc.zyngier@arm.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).