From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:48258 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751212AbcIIQGF (ORCPT <rfc822;stable@vger.kernel.org>);
        Fri, 9 Sep 2016 12:06:05 -0400
Subject: Re: [PATCH v2] irqchip/gic: Allow self-SGIs for SMP on UP
 configurations
To: Fabio Estevam <festevam@gmail.com>
References: <1473428682-14552-1-git-send-email-festevam@gmail.com>
 <57D2C9F1.5070900@arm.com>
 <CAOMZO5D1YmtW=5wHzJOH69Nio9_fyw76COxK_91keODSe_Pffg@mail.gmail.com>
 <57D2D868.7090205@arm.com>
 <CAOMZO5BAW0RgZe4w4bMEL8pvxZ8epesqPJRaujLxigphd6Nz4w@mail.gmail.com>
Cc: stable <stable@vger.kernel.org>,
        Fabio Estevam <fabio.estevam@nxp.com>
From: Marc Zyngier <marc.zyngier@arm.com>
Message-ID: <57D2DDEA.4050505@arm.com>
Date: Fri, 9 Sep 2016 17:06:02 +0100
MIME-Version: 1.0
In-Reply-To: <CAOMZO5BAW0RgZe4w4bMEL8pvxZ8epesqPJRaujLxigphd6Nz4w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 09/09/16 16:48, Fabio Estevam wrote:
> Hi Marc,
> 
> On Fri, Sep 9, 2016 at 12:42 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> 
>>> Without this patch imx6ul SoC hangs after a 'reboot' command.
>>
>> But that's not a regression, right? It *never* worked before, as far as
>> I know, because we never supported such a configuration in the past.
> 
> imx6ul is supported since kernel 4.3.

And yet nobody reported this as an issue until the 4.8 cycle. So it
doesn't look like it was annoying anyone until then.

> 
>> I'm a bit concerned when I see backporting random patches to random
>> kernel versions for things that are not bugs. I'll leave it up to Greg
>> to decide, but I thought I should point out what this patch actually is.
> 
> Not bugs? I consider the hang I get after running 'reboot' on imx6ul a bug.
> 
> According to Documentation/stable_kernel_rules.txt :
> 
> " - It must fix a problem that causes a build error (but not for things
>    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
>    security issue, or some "oh, that's not good" issue.  In short, something
>    critical. "
> 
> , so that's why I submitted for stable inclusion.
> 

I don't, which is why I didn't tag it for stable the first place. I
consider this as an unsupported configuration (MP CPU on a UP GIC),
which we start supporting from 4.8 onward.

Anyway, I'm not going to argue any further for such a small patch, but
I've made my position clear.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...