From: Vaishali Thakkar <vaishali.thakkar@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Wei Fang <fangwei1@huawei.com>,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
jack@suse.com, axboe@kernel.dk, tj@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput()
Date: Fri, 16 Sep 2016 18:20:53 +0530 [thread overview]
Message-ID: <57DBEAAD.6030101@oracle.com> (raw)
In-Reply-To: <20160916121023.GX2356@ZenIV.linux.org.uk>
On Friday 16 September 2016 05:40 PM, Al Viro wrote:
> On Fri, Sep 16, 2016 at 01:19:19PM +0530, Vaishali Thakkar wrote:
>
>> Hi,
>>
>> Just a question regarding this change. As after this change
>> dput() is sleepable, is it still safe to use if under the
>> spinlock in the function d_prune_aliases?
>
> It has always been sleepable and it wouldn't have been safe to use
> under spinlocks. Which d_prune_aliases() does not do - __dentry_kill()
> is called with dentry, its parent and its inode (if present) all locked and
> it drops all those locks before returning.
Ah, I see. Alright. Thanks for the clarification.
>
--
Vaishali
prev parent reply other threads:[~2016-09-16 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 3:01 [PATCH v2] fs/dcache.c: avoid soft-lockup in dput() Wei Fang
2016-06-22 6:51 ` Boqun Feng
2016-07-06 2:36 ` Wei Fang
2016-09-16 7:49 ` Vaishali Thakkar
2016-09-16 12:10 ` Al Viro
2016-09-16 12:50 ` Vaishali Thakkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DBEAAD.6030101@oracle.com \
--to=vaishali.thakkar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=fangwei1@huawei.com \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).