From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:47960 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbcIPMvO (ORCPT ); Fri, 16 Sep 2016 08:51:14 -0400 Subject: Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput() To: Al Viro References: <1466564475-30417-1-git-send-email-fangwei1@huawei.com> <57DBA3FF.4080201@oracle.com> <20160916121023.GX2356@ZenIV.linux.org.uk> Cc: Wei Fang , linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, jack@suse.com, axboe@kernel.dk, tj@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Vaishali Thakkar Message-ID: <57DBEAAD.6030101@oracle.com> Date: Fri, 16 Sep 2016 18:20:53 +0530 MIME-Version: 1.0 In-Reply-To: <20160916121023.GX2356@ZenIV.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Friday 16 September 2016 05:40 PM, Al Viro wrote: > On Fri, Sep 16, 2016 at 01:19:19PM +0530, Vaishali Thakkar wrote: > >> Hi, >> >> Just a question regarding this change. As after this change >> dput() is sleepable, is it still safe to use if under the >> spinlock in the function d_prune_aliases? > > It has always been sleepable and it wouldn't have been safe to use > under spinlocks. Which d_prune_aliases() does not do - __dentry_kill() > is called with dentry, its parent and its inode (if present) all locked and > it drops all those locks before returning. Ah, I see. Alright. Thanks for the clarification. > -- Vaishali