From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/1] usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices
Date: Thu, 17 Nov 2016 14:46:49 +0200 [thread overview]
Message-ID: <582DA6B9.3060704@linux.intel.com> (raw)
In-Reply-To: <20161117092609.GA17694@kroah.com>
On 17.11.2016 11:26, Greg KH wrote:
> On Thu, Nov 17, 2016 at 11:14:14AM +0200, Mathias Nyman wrote:
>> USB-3 does not have any link state that will avoid negotiating a connection
>> with a plugged-in cable but will signal the host when the cable is
>> unplugged.
>>
>> For USB-3 we used to first set the link to Disabled, then to RxDdetect to
>> be able to detect cable connects or disconnects. But in RxDetect the
>> connected device is detected again and eventually enabled.
>>
>> Instead set the link into U3 and disable remote wakeups for the device.
>> This is what Windows does, and what Alan Stern suggested.
>>
>> Cc: stable@vger.kernel.org
>> Cc: Alan Stern <stern@rowland.harvard.edu>
>> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>
> Can I put this in -next and get it some testing before going to Linus
> for 4.10-rc1, or do you think it needs to get into 4.9-final due to
> people complaining about this? If so, is it a regression or just
> something that we have never done before (I think the latter, but want
> to make sure...)
>
Latter, -next is fine.
I think this has always been an issue with usb3.
I found bugs from 2011 where users complained about this.
-Mathias
prev parent reply other threads:[~2016-11-17 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 9:14 [PATCH v3 1/1] usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices Mathias Nyman
2016-11-17 9:26 ` Greg KH
2016-11-17 12:46 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582DA6B9.3060704@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).