From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:1330 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754478AbcKQRP6 (ORCPT ); Thu, 17 Nov 2016 12:15:58 -0500 Subject: Re: [PATCH v3 1/1] usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices To: Greg KH References: <1479374054-19335-1-git-send-email-mathias.nyman@linux.intel.com> <20161117092609.GA17694@kroah.com> Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu, stable@vger.kernel.org From: Mathias Nyman Message-ID: <582DA6B9.3060704@linux.intel.com> Date: Thu, 17 Nov 2016 14:46:49 +0200 MIME-Version: 1.0 In-Reply-To: <20161117092609.GA17694@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 17.11.2016 11:26, Greg KH wrote: > On Thu, Nov 17, 2016 at 11:14:14AM +0200, Mathias Nyman wrote: >> USB-3 does not have any link state that will avoid negotiating a connection >> with a plugged-in cable but will signal the host when the cable is >> unplugged. >> >> For USB-3 we used to first set the link to Disabled, then to RxDdetect to >> be able to detect cable connects or disconnects. But in RxDetect the >> connected device is detected again and eventually enabled. >> >> Instead set the link into U3 and disable remote wakeups for the device. >> This is what Windows does, and what Alan Stern suggested. >> >> Cc: stable@vger.kernel.org >> Cc: Alan Stern >> Acked-by: Alan Stern >> Signed-off-by: Mathias Nyman > > Can I put this in -next and get it some testing before going to Linus > for 4.10-rc1, or do you think it needs to get into 4.9-final due to > people complaining about this? If so, is it a regression or just > something that we have never done before (I think the latter, but want > to make sure...) > Latter, -next is fine. I think this has always been an issue with usb3. I found bugs from 2011 where users complained about this. -Mathias