From: Matthieu Baerts <matttbe@kernel.org>
To: Shardul Bankar <shardul.b@mpiricsoftware.com>, mptcp@lists.linux.dev
Cc: martineau@kernel.org, geliang@kernel.org, pabeni@redhat.com,
janak@mpiric.us, kalpan.jani@mpiricsoftware.com,
shardulsb08@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH mptcp-net] mptcp: use MPTCP_RST_EMPTCP for ACK HMAC validation failure
Date: Tue, 28 Apr 2026 13:15:59 +0200 [thread overview]
Message-ID: <586311f0-277a-460c-aa5d-6612b5f32cb4@kernel.org> (raw)
In-Reply-To: <20260427234934.1611893-1-shardul.b@mpiricsoftware.com>
Hi Shardul,
On 28/04/2026 01:49, Shardul Bankar wrote:
> When HMAC validation fails on a received ACK + MP_JOIN in
> subflow_syn_recv_sock(), the subflow is reset with reason
> MPTCP_RST_EPROHIBIT ("Administratively prohibited"). This is
> incorrect: HMAC validation failure is an MPTCP protocol-level
> error, not an administrative policy denial.
>
> The mirror site on the client, in subflow_finish_connect(), already
> uses MPTCP_RST_EMPTCP ("MPTCP-specific error") for the same kind of
> HMAC failure on the SYN/ACK + MP_JOIN. Use the same reason on the
> server side for symmetry and accuracy.
Now in our tree:
New patches for t/upstream-net and t/upstream:
- 1f2cd6a4c385: mptcp: use MPTCP_RST_EMPTCP for ACK HMAC validation failure
- Results: 718fa635acef..90cb02b20cf2 (export-net)
- Results: 8e163e999320..f68dc562c883 (export)
Tests are now in progress:
- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/883745ff4a074154bb85f2be5a3aef39774f8e83/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/6f26689671ac282704c85b27521e6b309771c544/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2026-04-28 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 23:49 [PATCH mptcp-net] mptcp: use MPTCP_RST_EMPTCP for ACK HMAC validation failure Shardul Bankar
2026-04-28 11:15 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586311f0-277a-460c-aa5d-6612b5f32cb4@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=janak@mpiric.us \
--cc=kalpan.jani@mpiricsoftware.com \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=shardul.b@mpiricsoftware.com \
--cc=shardulsb08@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox