stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ziyuan <xzy.xu@rock-chips.com>
To: gregkh@linuxfoundation.org, randy.li@rock-chips.com,
	sgilles@math.umd.edu, shawn.lin@rock-chips.com,
	stable@vger.kernel.org, ulf.hansson@linaro.org
Subject: Re: WTF: patch "[PATCH] mmc: dw_mmc: force setup bus if active slots exist" was seriously submitted to be applied to the 4.9-stable tree?
Date: Mon, 6 Feb 2017 09:36:27 +0800	[thread overview]
Message-ID: <5897D31B.5070809@rock-chips.com> (raw)
In-Reply-To: <1485765844141224@kroah.com>

hi Greg,

On 01/30/2017 04:44 PM, gregkh@linuxfoundation.org wrote:
> The patch below was submitted to be applied to the 4.9-stable tree.
>
> I fail to see how this patch meets the stable kernel rules as found at
> Documentation/process/stable_kernel_rules.rst.
>
> I could be totally wrong, and if so, please respond to
> <stable@vger.kernel.org> and let me know why this patch should be
> applied.  Otherwise, it is now dropped from my patch queues, never to be
> seen again.

This patch is used for dw_mmc runtime feature fix, which will be land in 
4.10.
Sorry about it.

Best Regard
Ziyuan Xu

>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> >From e9748e0364fe82dc037d22900ff13a62d04518bf Mon Sep 17 00:00:00 2001
> From: Ziyuan Xu <xzy.xu@rock-chips.com>
> Date: Tue, 17 Jan 2017 09:22:56 +0800
> Subject: [PATCH] mmc: dw_mmc: force setup bus if active slots exist
>
> It's necessary to setup bus if any slots are present.
> - update clock after ctrl reset
> - if the host has genpd node, we can guarantee the clock is
>    available before starting request. Otherwies, the clock register
>    is reset once power off the pd, and host can't output the active
>    clock during communication.
>
> Fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback")
> Fixes: df9bcc2bc0a1 ("mmc: dw_mmc: add missing codes for runtime resume")
> cc: <stable@vger.kernel.org>
> Reported-by: Randy Li <randy.li@rock-chips.com>
> Reported-by: S. Gilles <sgilles@math.umd.edu>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index b44306b886cb..73db08558e4d 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3354,10 +3354,11 @@ int dw_mci_runtime_resume(struct device *dev)
>   
>   		if (!slot)
>   			continue;
> -		if (slot->mmc->pm_flags & MMC_PM_KEEP_POWER) {
> +		if (slot->mmc->pm_flags & MMC_PM_KEEP_POWER)
>   			dw_mci_set_ios(slot->mmc, &slot->mmc->ios);
> -			dw_mci_setup_bus(slot, true);
> -		}
> +
> +		/* Force setup bus to guarantee available clock output */
> +		dw_mci_setup_bus(slot, true);
>   	}
>   
>   	/* Now that slots are all setup, we can enable card detect */
>
>
>
>



      reply	other threads:[~2017-02-06  1:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30  8:44 WTF: patch "[PATCH] mmc: dw_mmc: force setup bus if active slots exist" was seriously submitted to be applied to the 4.9-stable tree? gregkh
2017-02-06  1:36 ` Ziyuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5897D31B.5070809@rock-chips.com \
    --to=xzy.xu@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=randy.li@rock-chips.com \
    --cc=sgilles@math.umd.edu \
    --cc=shawn.lin@rock-chips.com \
    --cc=stable@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).