From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from regular1.263xmail.com ([211.150.99.136]:52319 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdBFBgk (ORCPT ); Sun, 5 Feb 2017 20:36:40 -0500 Subject: Re: WTF: patch "[PATCH] mmc: dw_mmc: force setup bus if active slots exist" was seriously submitted to be applied to the 4.9-stable tree? To: gregkh@linuxfoundation.org, randy.li@rock-chips.com, sgilles@math.umd.edu, shawn.lin@rock-chips.com, stable@vger.kernel.org, ulf.hansson@linaro.org References: <1485765844141224@kroah.com> From: Ziyuan Message-ID: <5897D31B.5070809@rock-chips.com> Date: Mon, 6 Feb 2017 09:36:27 +0800 MIME-Version: 1.0 In-Reply-To: <1485765844141224@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: hi Greg, On 01/30/2017 04:44 PM, gregkh@linuxfoundation.org wrote: > The patch below was submitted to be applied to the 4.9-stable tree. > > I fail to see how this patch meets the stable kernel rules as found at > Documentation/process/stable_kernel_rules.rst. > > I could be totally wrong, and if so, please respond to > and let me know why this patch should be > applied. Otherwise, it is now dropped from my patch queues, never to be > seen again. This patch is used for dw_mmc runtime feature fix, which will be land in 4.10. Sorry about it. Best Regard Ziyuan Xu > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > >From e9748e0364fe82dc037d22900ff13a62d04518bf Mon Sep 17 00:00:00 2001 > From: Ziyuan Xu > Date: Tue, 17 Jan 2017 09:22:56 +0800 > Subject: [PATCH] mmc: dw_mmc: force setup bus if active slots exist > > It's necessary to setup bus if any slots are present. > - update clock after ctrl reset > - if the host has genpd node, we can guarantee the clock is > available before starting request. Otherwies, the clock register > is reset once power off the pd, and host can't output the active > clock during communication. > > Fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback") > Fixes: df9bcc2bc0a1 ("mmc: dw_mmc: add missing codes for runtime resume") > cc: > Reported-by: Randy Li > Reported-by: S. Gilles > Signed-off-by: Ziyuan Xu > Signed-off-by: Shawn Lin > Signed-off-by: Ulf Hansson > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index b44306b886cb..73db08558e4d 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -3354,10 +3354,11 @@ int dw_mci_runtime_resume(struct device *dev) > > if (!slot) > continue; > - if (slot->mmc->pm_flags & MMC_PM_KEEP_POWER) { > + if (slot->mmc->pm_flags & MMC_PM_KEEP_POWER) > dw_mci_set_ios(slot->mmc, &slot->mmc->ios); > - dw_mci_setup_bus(slot, true); > - } > + > + /* Force setup bus to guarantee available clock output */ > + dw_mci_setup_bus(slot, true); > } > > /* Now that slots are all setup, we can enable card detect */ > > > >