From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:31840 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406AbdC1K33 (ORCPT ); Tue, 28 Mar 2017 06:29:29 -0400 Subject: Re: [PATCH v2 3/3] xhci: Manually give back cancelled URB if queuing it for cancel fails To: Felipe Balbi , gregkh@linuxfoundation.org References: <1490624830-9761-1-git-send-email-mathias.nyman@linux.intel.com> <1490624830-9761-4-git-send-email-mathias.nyman@linux.intel.com> <874lyekbwg.fsf@linux.intel.com> <58D92DA0.4040808@linux.intel.com> <87y3vpj3q4.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org From: Mathias Nyman Message-ID: <58DA3B47.1000700@linux.intel.com> Date: Tue, 28 Mar 2017 13:30:31 +0300 MIME-Version: 1.0 In-Reply-To: <87y3vpj3q4.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 28.03.2017 09:49, Felipe Balbi wrote: > > Hi, > > Mathias Nyman writes: >> On 27.03.2017 17:54, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Mathias Nyman writes: >>>> Manually give back URB if we are can not add it to the cancel queue, and >>>> stop the endpoint normally. >>> >>> this sentence doesn't parse very well ;-) >>> >>>> This can happen if device just reset before URB timed out and dequeued, >>>> leading to missing endpoint ring. >>> >>> seems like this could be extended a bit too. >>> I'll clean up those commit messages, and modify patch 2/3 a bit to only touch the error message and URB actual_length for endpoint stopped at status stage. This way there is as little change going to usb-linus and stable as possible, saving the reset for usb-next -Mathias