From: Baolu Lu <baolu.lu@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
kernel test robot <oliver.sang@intel.com>,
iommu@lists.linux.dev, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: avoid invalid memory access via node_online(NUMA_NO_NODE)
Date: Wed, 13 Jul 2022 08:02:41 +0800 [thread overview]
Message-ID: <597af953-b09d-f893-cdce-fa5d840e5cfe@linux.intel.com> (raw)
In-Reply-To: <CAAH8bW8-JL=q_4c_AKROsjC7KyuRWDMFNKBz=6uT+d1mStTE2A@mail.gmail.com>
On 2022/7/12 23:54, Yury Norov wrote:
> On Tue, Jul 12, 2022 at 8:45 AM Alexander Lobakin
> <alexandr.lobakin@intel.com> wrote:
>>
>> From: Alexander Lobakin <alexandr.lobakin@intel.com>
>> Date: Tue, 12 Jul 2022 17:38:36 +0200
>>
>>> KASAN reports:
>>>
>>> [ 4.668325][ T0] BUG: KASAN: wild-memory-access in dmar_parse_one_rhsa (arch/x86/include/asm/bitops.h:214 arch/x86/include/asm/bitops.h:226 include/asm-generic/bitops/instrumented-non-atomic.h:142 include/linux/nodemask.h:415 drivers/iommu/intel/dmar.c:497)
>>> [ 4.676149][ T0] Read of size 8 at addr 1fffffff85115558 by task swapper/0/0
>>> [ 4.683454][ T0]
>>> [ 4.685638][ T0] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc3-00004-g0e862838f290 #1
>>> [ 4.694331][ T0] Hardware name: Supermicro SYS-5018D-FN4T/X10SDV-8C-TLN4F, BIOS 1.1 03/02/2016
>>> [ 4.703196][ T0] Call Trace:
>>> [ 4.706334][ T0] <TASK>
>>> [ 4.709133][ T0] ? dmar_parse_one_rhsa (arch/x86/include/asm/bitops.h:214 arch/x86/include/asm/bitops.h:226 include/asm-generic/bitops/instrumented-non-atomic.h:142 include/linux/nodemask.h:415 drivers/iommu/intel/dmar.c:497)
>>>
>>> after converting the type of the first argument (@nr, bit number)
>>> of arch_test_bit() from `long` to `unsigned long`[0].
>>>
>>> Under certain conditions (for example, when ACPI NUMA is disabled
>>> via command line), pxm_to_node() can return %NUMA_NO_NODE (-1).
>>> It is valid 'magic' number of NUMA node, but not valid bit number
>>> to use in bitops.
>>> node_online() eventually descends to test_bit() without checking
>>> for the input, assuming it's on caller side (which might be good
>>> for perf-critical tasks). There, -1 becomes %ULONG_MAX which leads
>>> to an insane array index when calculating bit position in memory.
>>>
>>> For now, add an explicit check for @node being not %NUMA_NO_NODE
>>> before calling test_bit(). The actual logics didn't change here
>>> at all.
>>
>> Bah, forgot to insert the link here. Hope not worth resending ._.
>>
>> [0] https://github.com/norov/linux/commit/0e862838f290147ea9c16db852d8d494b552d38d
>
> I'll add this link and apply the patch to the bitmap-for-next, after
> some testing.
Thank you!
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
next prev parent reply other threads:[~2022-07-13 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 15:38 [PATCH] iommu/vt-d: avoid invalid memory access via node_online(NUMA_NO_NODE) Alexander Lobakin
2022-07-12 15:44 ` Alexander Lobakin
2022-07-12 15:54 ` Yury Norov
2022-07-13 0:02 ` Baolu Lu [this message]
2022-07-12 16:00 ` Andy Shevchenko
2022-07-13 16:13 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=597af953-b09d-f893-cdce-fa5d840e5cfe@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=oliver.sang@intel.com \
--cc=stable@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox