RE: Re: [PATCH 01/12] PM / devfreq: Fix memory leak when fail to register device

MyungJoo Ham
2017-08-28T01:30:29Z

> On 2017년 08월 28일 09:17, MyungJoo Ham wrote:

> >> When the devfreq_add_device fails to register deivce, the memory

> >> leak of devfreq instance happen. So, this patch fix the memory

> >> leak issue. Before freeing the devfreq instance checks whether

> >> devfreq instance is NULL or not because the device_unregister()

> >> frees the devfreq instance when jumping to the 'err_init'.

> >> It is to prevent the duplicate the kfee(devfreq).

> >>

> >> Cc: stable@vger.kernel.org

> >> Fixes: ac4b281176a5 ("PM / devfreq: fix duplicated kfree on devfreq pointer")

> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

> >> ---

> >> drivers/devfreq/devfreq.c | 5 ++++-

> >> 1 file changed, 4 insertions(+), 1 deletion(-)

> >

> > This looks like to be duplicated. Please check your repo basis.

>

> These patches is based on the v4.13-rc6.

>

> After merged ("PM / devfreq: fix duplicated kfree on devfreq pointer"),

> this patch doesn't consider the free of memory when error case.

>

> After applying this patch, this patch consider the error case

> when jumping the err_dev statement with goto.

> device_unregister(&devfreq->dev);

> err_dev:

> if (devfreq)

> kfree(devfreq);

Ah sorry. It looks like I was confused of - and + somehow.

Acked-By: MyungJoo Ham.

(I'll merge trivial fixes first)

>

>