* [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status @ 2018-02-06 8:10 ` Hans de Goede 2018-02-06 8:14 ` Chanwoo Choi 0 siblings, 1 reply; 3+ messages in thread From: Hans de Goede @ 2018-02-06 8:10 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi; +Cc: Hans de Goede, linux-kernel, stable Some other drivers may be waiting for our extcon to show-up (exiting their probe methods with -EPROBE_DEFER until we show up). These drivers will typically get the cable state directly after getting the extcon, this commit changes the int3496 code to process the id-pin before registering the extcon, so that other drivers see the correct state right away. Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/extcon/extcon-intel-int3496.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c index c8691b5a9cb0..b23ee9d993a3 100644 --- a/drivers/extcon/extcon-intel-int3496.c +++ b/drivers/extcon/extcon-intel-int3496.c @@ -131,6 +131,10 @@ static int int3496_probe(struct platform_device *pdev) if (IS_ERR(data->gpio_usb_mux)) dev_info(dev, "can't request USB MUX GPIO\n"); + /* process id-pin first so that we start with the right status */ + queue_delayed_work(system_wq, &data->work, 0); + flush_delayed_work(&data->work); + /* register extcon device */ data->edev = devm_extcon_dev_allocate(dev, int3496_cable); if (IS_ERR(data->edev)) @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev) return ret; } - /* queue initial processing of id-pin */ - queue_delayed_work(system_wq, &data->work, 0); - platform_set_drvdata(pdev, data); return 0; -- 2.14.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status 2018-02-06 8:10 ` [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status Hans de Goede @ 2018-02-06 8:14 ` Chanwoo Choi 2018-02-11 23:41 ` Chanwoo Choi 0 siblings, 1 reply; 3+ messages in thread From: Chanwoo Choi @ 2018-02-06 8:14 UTC (permalink / raw) To: Hans de Goede, MyungJoo Ham; +Cc: linux-kernel, stable On 2018년 02월 06일 17:10, Hans de Goede wrote: > Some other drivers may be waiting for our extcon to show-up (exiting their > probe methods with -EPROBE_DEFER until we show up). > > These drivers will typically get the cable state directly after getting > the extcon, this commit changes the int3496 code to process the id-pin > before registering the extcon, so that other drivers see the correct state > right away. > > Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver") > Cc: stable@vger.kernel.org > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/extcon/extcon-intel-int3496.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status 2018-02-06 8:14 ` Chanwoo Choi @ 2018-02-11 23:41 ` Chanwoo Choi 0 siblings, 0 replies; 3+ messages in thread From: Chanwoo Choi @ 2018-02-11 23:41 UTC (permalink / raw) To: Hans de Goede, MyungJoo Ham; +Cc: linux-kernel, stable On 2018년 02월 06일 17:14, Chanwoo Choi wrote: > On 2018년 02월 06일 17:10, Hans de Goede wrote: >> Some other drivers may be waiting for our extcon to show-up (exiting their >> probe methods with -EPROBE_DEFER until we show up). >> >> These drivers will typically get the cable state directly after getting >> the extcon, this commit changes the int3496 code to process the id-pin >> before registering the extcon, so that other drivers see the correct state >> right away. >> >> Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver") >> Cc: stable@vger.kernel.org >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/extcon/extcon-intel-int3496.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > Applied it. Thanks. > This patch had the bug reported by Hans. Please ignore what I applied patch. I don't apply it and I'll wait v3 patch. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-11 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180206081056epcas2p19485991e157843cf2e016a6dfed41027@epcas2p1.samsung.com>
2018-02-06 8:10 ` [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status Hans de Goede
2018-02-06 8:14 ` Chanwoo Choi
2018-02-11 23:41 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).