From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.samsung.com ([203.254.224.25]:63131 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbeBLVup (ORCPT ); Mon, 12 Feb 2018 16:50:45 -0500 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A820C33.5000209@samsung.com> Date: Tue, 13 Feb 2018 06:50:43 +0900 From: Chanwoo Choi To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status In-reply-to: <20180212194630.7216-3-hdegoede@redhat.com> References: <20180212194630.7216-1-hdegoede@redhat.com> <20180212194630.7216-3-hdegoede@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: On 2018년 02월 13일 04:46, Hans de Goede wrote: > Some other drivers may be waiting for our extcon to show-up (exiting their > probe methods with -EPROBE_DEFER until we show up). > > These drivers will typically get the cable state directly after getting > the extcon, this commit changes the int3496 code to process the id-pin > before registering the extcon, so that other drivers see the correct state > right away. > > Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver") > Cc: stable@vger.kernel.org > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Add Fixes tag > > Changes in v3: > -Fix oops on probe by scheduling the work too early > --- > drivers/extcon/extcon-intel-int3496.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index c8691b5a9cb0..673bb26a9a2a 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -131,11 +131,15 @@ static int int3496_probe(struct platform_device *pdev) > if (IS_ERR(data->gpio_usb_mux)) > dev_info(dev, "can't request USB MUX GPIO\n"); > > - /* register extcon device */ > data->edev = devm_extcon_dev_allocate(dev, int3496_cable); > if (IS_ERR(data->edev)) > return -ENOMEM; > > + /* process id-pin first so that we start with the right status */ > + queue_delayed_work(system_wq, &data->work, 0); > + flush_delayed_work(&data->work); > + > + /* register extcon device */ > ret = devm_extcon_dev_register(dev, data->edev); > if (ret < 0) { > dev_err(dev, "can't register extcon device: %d\n", ret); > @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev) > return ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, &data->work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Applied it. -- Best Regards, Chanwoo Choi Samsung Electronics