From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Mark Hasemeyer" <markhas@chromium.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
stable@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Brady Norander <bradynorander@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v1] ALSA: hda: intel-dsp-config: Fix JSL Chromebook quirk detection
Date: Thu, 19 Oct 2023 12:00:19 -0500 [thread overview]
Message-ID: <5bc82aca-04f2-463b-ba52-34bcae6724d5@linux.intel.com> (raw)
In-Reply-To: <CANg-bXDvZ00ZHEgbUf1NwDrOKfDF4vpBOxZ4hGEp-ohs6-pZpw@mail.gmail.com>
On 10/19/23 11:43, Mark Hasemeyer wrote:
>> I would assume that platform that has DMI_SYS_VENDOR set to "Google",
>> also has DMI_BIOS_VERSION set to "Google", so perhaps just replace
>> DMI_SYS_VENDOR match with DMI_BIOS_VERSION, to keep table small? Or is
>> that not a case?
>
> That is the case. But I'm inclined to keep it for two reasons:
> 1. There is precedent in the kernel to use DMI_SYS_VENDOR=="Google"
> for Chromebook detection.
> 2. If the coreboot version schema for Chromebooks were to change, this
> check would fail for all JSL Chromebooks instead of just a few models.
I also prefer a low-risk addition to a higher-risk change. It's not like
we really care about the size of the table at this point.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
FWIW we use this other quirk:
DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"),
How many engineers does it take to identify a Chromebook, eh?
next prev parent reply other threads:[~2023-10-20 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 23:59 [PATCH v1] ALSA: hda: intel-dsp-config: Fix JSL Chromebook quirk detection Mark Hasemeyer
2023-10-19 14:22 ` Amadeusz Sławiński
2023-10-19 16:43 ` Mark Hasemeyer
2023-10-19 17:00 ` Pierre-Louis Bossart [this message]
2023-10-20 15:36 ` Mark Hasemeyer
2023-10-20 16:59 ` Pierre-Louis Bossart
2023-10-20 19:35 ` Mark Hasemeyer
2023-10-20 15:40 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc82aca-04f2-463b-ba52-34bcae6724d5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bradynorander@gmail.com \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markhas@chromium.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox