From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Jarkko Sakkinen <jarkko@kernel.org>, Tadeusz Struk <tstruk@gmail.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tpm: Fix error handling in async work
Date: Thu, 6 Jan 2022 18:51:41 -0800 [thread overview]
Message-ID: <5d6ebe64-df5b-9cc5-be08-a550dec296f8@linaro.org> (raw)
In-Reply-To: <883e4ac1a10dc192824dff3eb6489d027417d1d4.camel@kernel.org>
On 1/5/22 12:05, Jarkko Sakkinen wrote:
>> until the user_read_timer wakes it up after 120 sec.
>> Make sure that error conditions also contribute to the poll mask
>> so that a correct error code could passed back to the caller.
> I'm not sure what "making sure" means.
>
>> tpm_put_ops(priv->chip);
>> - if (ret > 0) {
>> + if (ret != 0) {
> What if ret < 0?
>
> You should explain this change in the commit message. Also, consider
> adding an inline comment.
As the commit message says tpm_dev_transmit() returns -EINVAL when
the given handle doesn't exist, and the tmprm can not find it.
This is not handled properly and the application gets stuck.
I will add a comment here send a new version.
--
Thanks,
Tadeusz
prev parent reply other threads:[~2022-01-07 2:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 5:06 [PATCH v2 1/2] tpm: Fix error handling in async work Tadeusz Struk
2022-01-05 20:05 ` Jarkko Sakkinen
2022-01-07 2:51 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6ebe64-df5b-9cc5-be08-a550dec296f8@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tstruk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).