From: Ben Greear <greearb@candelatech.com>
To: Joshua Klinesmith <joshuaklinesmith@gmail.com>
Cc: linux-wireless@vger.kernel.org, nbd@nbd.name, lorenzo@kernel.org,
ryder.lee@mediatek.com, shayne.chen@mediatek.com,
sean.wang@mediatek.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH wireless 4/4] wifi: mt76: mt7925: fix RCPI chain 3 mask in sta_poll RSSI extraction
Date: Tue, 7 Apr 2026 10:31:04 -0700 [thread overview]
Message-ID: <5e197844-804e-51d7-a1de-e9e7686bad0a@candelatech.com> (raw)
In-Reply-To: <CANs=ypgceH4NL5xOr2C1FPp8KvDCcUWTu10i+DiXntuOmAfJVA@mail.gmail.com>
On 4/7/26 09:58, Joshua Klinesmith wrote:
> On 4/7/26 12:31, Ben Greear wrote:
>> I am more concerned about the trickier patches that you have been posting
>> that is utilizing work from upstream vendor code. How much of that is pure
>> AI driven? How much testing has been done to see if there are actual stability
>> or performance improvements when testing actual hardware?
>
> Hi Ben,
>
> To be straightforward: my workflow involves pulling GitHub issues into
> AI prompts along with firmware analysis tooling to identify potential
> fixes. I have an MT6000 available, but I have not been doing thorough
> on-hardware testing before submitting. That is a gap I need to close.
>
> I will hold off on submitting further patches to the mt76 driver until
> I have a proper test workflow in place and can verify changes on real
> hardware.
>
> I appreciate you raising this directly.
Please be sure to add note about using AI to patch submissions,
and link to original bug reports you are trying to fix.
Possibly some of this is useful, but you need to do significant tests
with real hardware if you are proposing non-trivial changes.
If you are referencing publicly available upstream driver source, then
be clear about that and provide links. 'Reverse Engineering' could mean a lot of things,
some of which is grey area for patch submission. If you talked some AI bot
into finding non public source, or if it can actually generate useful c code out of
vendor binaries, then I am not sure how legit that is to even post.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2026-04-07 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260406234739.29926-1-joshuaklinesmith@gmail.com>
2026-04-06 23:47 ` [PATCH wireless 1/4] wifi: mt76: mt7915: fix RCPI chain 3 mask in sta_poll RSSI extraction Joshua Klinesmith
2026-04-06 23:47 ` [PATCH wireless 2/4] wifi: mt76: mt7996: " Joshua Klinesmith
2026-04-06 23:47 ` [PATCH wireless 3/4] wifi: mt76: mt7921: " Joshua Klinesmith
2026-04-06 23:47 ` [PATCH wireless 4/4] wifi: mt76: mt7925: " Joshua Klinesmith
2026-04-07 15:25 ` Ben Greear
2026-04-07 16:00 ` Joshua Klinesmith
2026-04-07 16:31 ` Ben Greear
2026-04-07 16:58 ` Joshua Klinesmith
2026-04-07 17:31 ` Ben Greear [this message]
2026-04-07 17:35 ` Joshua Klinesmith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e197844-804e-51d7-a1de-e9e7686bad0a@candelatech.com \
--to=greearb@candelatech.com \
--cc=joshuaklinesmith@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox