From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:34747 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbeCCJOo (ORCPT ); Sat, 3 Mar 2018 04:14:44 -0500 Received: by mail-wm0-f68.google.com with SMTP id a20so6079353wmd.1 for ; Sat, 03 Mar 2018 01:14:44 -0800 (PST) Subject: Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host after reset To: Ben Hutchings , Oliver Neukum Cc: stable@vger.kernel.org, Greg Kroah-Hartman , LKML References: <20180202140815.091718203@linuxfoundation.org> <20180202140822.268335379@linuxfoundation.org> <1520036364.2786.39.camel@codethink.co.uk> From: Hans de Goede Message-ID: <5ed38173-5fd6-eaa2-b838-632829471aec@redhat.com> Date: Sat, 3 Mar 2018 10:14:42 +0100 MIME-Version: 1.0 In-Reply-To: <1520036364.2786.39.camel@codethink.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: Hi, On 03-03-18 01:19, Ben Hutchings wrote: > On Fri, 2018-02-02 at 17:58 +0100, Greg Kroah-Hartman wrote: >> 4.4-stable review patch.  If anyone has any objections, please let me know. >> >> ------------------ >> >> From: Oliver Neukum >> >> commit cbeef22fd611c4f47c494b821b2b105b8af970bb upstream. > [...] >> --- a/drivers/usb/storage/uas.c >> +++ b/drivers/usb/storage/uas.c >> @@ -1052,20 +1052,19 @@ static int uas_post_reset(struct usb_int >>   return 0; >> >>   err = uas_configure_endpoints(devinfo); >> - if (err) { >> + if (err && err != ENODEV) >>   shost_printk(KERN_ERR, shost, >>        "%s: alloc streams error %d after reset", >>        __func__, err); > [...] > > This should be checking for -ENODEV, shouldn't it? Yes you're right, the check should be != -ENODEV. Oliver can you do a follow-up patch fixing this please? Regards, Hans