From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:37736 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbeGTJYn (ORCPT ); Fri, 20 Jul 2018 05:24:43 -0400 Received: by mail-wm0-f43.google.com with SMTP id a19-v6so8899166wmb.2 for ; Fri, 20 Jul 2018 01:37:32 -0700 (PDT) Subject: Re: request for 4.14-stable: 1dc3039bc87a ("block: do not use interruptible wait anywhere") To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Bart Van Assche , stable@vger.kernel.org, Jens Axboe References: <20180719220936.wala6fa7st6q3xok@debian> From: Alan Jenkins Message-ID: <5f24dbd5-3c1d-9cab-eeca-467a4dd38a2d@gmail.com> Date: Fri, 20 Jul 2018 09:37:29 +0100 MIME-Version: 1.0 In-Reply-To: <20180719220936.wala6fa7st6q3xok@debian> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Sender: stable-owner@vger.kernel.org List-ID: On 19/07/18 23:09, Sudip Mukherjee wrote: > Hi Greg, > > This was missing in 4.14-stable. Please apply to your queue. > > -- > Regards > Sudip Hi Sudip, This is correct, seems low-risk, and I don't mind it going ahead. But I'm curious� why you're interested in it for v4.14.� Mostly, I wonder if the same reason would apply to older kernels as well? While the bugfix is applicable to v4.14, the nasty X crash on suspend is only on v4.15 and v4.16.� I think I left it to other's judgement, as to whether the bugfix would be wanted outside that case. IIUC, the bugfix could be applied to *three* of the "longterm" kernel lines: 4.14.56, 4.9.113, 4.4.142.� Since the commit says this bug was introduced to the single-queue block layer in v4.4, commit 3ef28e8 ("block: generic request_queue reference counting"). Regards Alan******