From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mout.kundenserver.de ([212.227.126.187]:57752 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1425080AbcBRQrI (ORCPT
	<rfc822;stable@vger.kernel.org>); Thu, 18 Feb 2016 11:47:08 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: Tejun Heo <tj@kernel.org>, linux-ide@vger.kernel.org,
	Alban Bedel <albeu@free.fr>,
	Ralf Baechle <ralf@linux-mips.org>, stable@vger.kernel.org
Subject: Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call
Date: Thu, 18 Feb 2016 17:46:59 +0100
Message-ID: <61574946.qI16Kz5bLp@wuerfel>
In-Reply-To: <1455710300-30920-1-git-send-email-juhosg@openwrt.org>
References: <1455710300-30920-1-git-send-email-juhosg@openwrt.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wednesday 17 February 2016 12:58:20 Gabor Juhos wrote:
> The RB532 platform specific irq_to_gpio() implementation has been
> removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of
> custom gpio.h"). Now the platform uses the generic stub which causes
> the following error:
> 
>   pata-rb532-cf pata-rb532-cf: no GPIO found for irq149
>   pata-rb532-cf: probe of pata-rb532-cf failed with error -2
> 
> Drop the irq_to_gpio() call and get the GPIO number from platform
> data instead. After this change, the driver works again:
> 
>   scsi host0: pata-rb532-cf
>   ata1: PATA max PIO4 irq 149
>   ata1.00: CFA: CF 1GB, 20080820, max MWDMA4
>   ata1.00: 1989792 sectors, multi 0: LBA
>   ata1.00: configured for PIO4
>   scsi 0:0:0:0: Direct-Access     ATA      CF 1GB           0820 PQ: 0\
>   ANSI: 5
>   sd 0:0:0:0: [sda] 1989792 512-byte logical blocks: (1.01 GB/971 MiB)
>   sd 0:0:0:0: [sda] Write Protect is off
>   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't\
>   support DPO or FUA
>    sda: sda1 sda2
>   sd 0:0:0:0: [sda] Attached SCSI disk
> 
> Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> Cc: Alban Bedel <albeu@free.fr>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

The patch looks good, but I now saw that drivers/pcmcia/db1xxx_ss.c
must have been broken by the same patch as this one, and it probably
needs a similar fix.

	Arnd