From: Paolo Abeni <pabeni@redhat.com>
To: "Lekë Hapçiu" <snowwlake@icloud.com>, netdev@vger.kernel.org
Cc: linux-nfc@lists.01.org, stable@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Subject: Re: [PATCH net 0/3] nfc: llcp: fix OOB reads in TLV parsers and PDU handlers
Date: Tue, 14 Apr 2026 10:11:29 +0200 [thread overview]
Message-ID: <6191cfae-db06-4a4c-8e82-7e17ba0ffa6e@redhat.com> (raw)
In-Reply-To: <20260409233517.1891497-1-snowwlake@icloud.com>
On 4/10/26 1:35 AM, Lekë Hapçiu wrote:
> This series fixes three out-of-bounds read vulnerabilities in the NFC
> LLCP layer, all reachable from RF without prior pairing or session
> establishment.
>
> Patch 1 adds missing TLV length bounds checks in nfc_llcp_parse_gb_tlv()
> and nfc_llcp_parse_connection_tlv() — a crafted CONNECT or SNL PDU
> containing a short TLV value field can read beyond the skb tail.
>
> Patch 2 fixes nfc_llcp_recv_snl(), which accessed TLV fields and
> performed arithmetic on an uncapped length byte before any bounds
> check, enabling a 1-byte heap OOB read and a u8 wrap-around.
>
> Patch 3 fixes nfc_llcp_recv_dm(), which read the DM reason byte at
> skb->data[2] without verifying the frame is at least 3 bytes long.
> A 2-byte DM PDU (header only) from a rogue peer triggers a 1-byte
> OOB heap read.
>
> All three bugs are independently triggered via RF (AV:A, AC:L, no
> authentication required).
This series looks like an older iteration of:
https://patchwork.kernel.org/user/todo/netdevbpf/?series=1079400
but it reached the ML 2h afterwards?!?
At very best you have some serious setup issue. Please have a look at
the repost policy and especially at the 24h grace period:
https://elixir.bootlin.com/linux/v7.0/source/Documentation/process/maintainer-netdev.rst
And, given the above problem, please do not share any more patches for
at least 48h.
/P
prev parent reply other threads:[~2026-04-14 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 23:35 [PATCH net 0/3] nfc: llcp: fix OOB reads in TLV parsers and PDU handlers Lekë Hapçiu
2026-04-09 23:35 ` [PATCH net 1/3] nfc: llcp: add TLV length bounds checks in parse_gb_tlv and parse_connection_tlv Lekë Hapçiu
2026-04-09 23:35 ` [PATCH net 2/3] nfc: llcp: fix TLV parsing OOB and length underflow in nfc_llcp_recv_snl Lekë Hapçiu
2026-04-09 23:35 ` [PATCH net 3/3] nfc: llcp: fix OOB read of DM reason byte in nfc_llcp_recv_dm() Lekë Hapçiu
2026-04-14 8:11 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6191cfae-db06-4a4c-8e82-7e17ba0ffa6e@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=snowwlake@icloud.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox