From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4621C6FD1D for ; Fri, 7 Apr 2023 11:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238567AbjDGL4x (ORCPT ); Fri, 7 Apr 2023 07:56:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbjDGL4w (ORCPT ); Fri, 7 Apr 2023 07:56:52 -0400 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 514A649CE for ; Fri, 7 Apr 2023 04:56:50 -0700 (PDT) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4PtH0F3LbLz9scK; Fri, 7 Apr 2023 13:56:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1680868605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5xFptS78ryJWQ9T89ayX33Yedi3fouqi4tSdbu3AxuE=; b=J13gtFY7eoNVRQGOHjplbmWA2ftAwVNrSdN5OL5sqyWWrrMk03NpeToaS2plg6eT+H5wW+ TiK+0MjzDDav0pEhQqYjMTBSG5V+L4wS26DQV/lbF62K8aASAxVyrfcaZBbluyD+exlf15 ppWRQqBvZSax0F7eTv8whTZTpcfPIzWrPey/BgMo75euWlgDNNDA7sM68yrx/7lJTdFaGy fL/KEG9DqFYhewUg83KFZtL7GaefbX9eywSRPf+cRGDsTfki8D5UXwFuPwwBJUJ7DIPnHx 45sNlZIxOwAwAtSv7eNsgD7G4VdzKx5al4yaPnqASDmv9mPXMqGaNygs53vdxA== Subject: Re: 6.1.22: Resume from hibernate fails; bisected To: Greg KH Cc: Linux regressions mailing list , stable@vger.kernel.org, tim.huang@amd.com, Alex Deucher References: From: Rainer Fiebig Autocrypt: addr=jrf@mailbox.org; prefer-encrypt=mutual; keydata= mQINBFohwNMBEADSyoSeizfx3D4yl2vTXfNamkLDCuXDN+7P5/UbB+Kj/d4RTbA/w0fqu3S3 Kdc/mff99ypi59ryf8VAwd3XM19beUrDZVTU1/3VHn/gVYaI0/k7cnPpEaOgYseemBX5P2OV ZE/MjfQrdxs80ThMqFs2dV1eHnDyNiI3FRV8zZ5xPeOkwvXakAOcWQA7Jkxmdc3Zmc1s1q8p ZWz77UQ5RRMUFw7Z9l0W1UPhOwr/sBPMuKQvGdW+eui3xOpMKDYYgs7uN4Ftg4vsiMEo03i5 qrK0mfueA73NADuVIf9cB2STDywF/tF1I27r+fWns1x9j/hKEPOAf4ACrNUdwQ9qzu7Nj9rz 2WU8sjneqiiED2nKdzV0gDnFkvXY9HCFZR2YUC2BZNvLiUJ1PROFDdNxmdbLZAKok17mPyOR MU0VQ61+PNjS8nsnAml8jnpzpcvLcQxR7ejRAV6w+Dc7JwnuQOiPS6M7x5FTk3QTPL+rvLFJ 09Nb3ooeIQ/OUQoeM7pW8ll8Tmu2qSAJJ+3O002ADRVU1Nrc9tM5Ry9ht5zjmsSnFcSe2GoJ Knu1hyXHDAvcq/IffOwzdeVstdhotBpf058jlhFlfnaqXcOaaHZrlHtrKOfQQZrxXMfcrvyv iE2yhO8lUpoDOVuC1EhSidLd/IkCyfPjfIEBjQsQts7lepDgpQARAQABtB9SYWluZXIgRmll YmlnIDxqcmZAbWFpbGJveC5vcmc+iQJWBBMBCABAAhsjBwsJCAcDAgEGFQgCCQoLBBYCAwEC HgECF4AWIQTrLHk+ME24YHaolcbw4fcmJYr49QUCYVlg+QUJGnvH3QAKCRDw4fcmJYr49Wta EADHXEnPxIsw5dM0Brphds0y12D0YGc2fBuTeyEDltuJIJNNLkzRw3wTOJ/muUHePlyWQigf cTieAP4UZmZkR+HtZdbasop+cIqjNrjeU1i+aiNaDf/j6JMKaXVtaXfTbwA0DFJ2olS7Ito/ v7WPf5zJa7BnWFa5VbMQw2T68gOGpMuQky9se58ylQcpjBD2QVJiL5w36JTZpG84GfvQnFdl Fu9dh6/bYDUiTVYWbWCYNoDiEam3GEgsPxWMyb2R9nkBDEUKp9jDxu/iJl5nbX2+hoLDcD7v zM+sEeXLgwn5OyRxKiFYLAaNPUow+J8JG7NUWHVvuHtiu4ykNfoIghyxPENs5N/nndJt5KDq kWHlXhJOyC6eDCt/47Ylykau/bDlfrmgfoEoLt8X59sZaQAgkV0yjrPl4bEW61eGvcjracj5 lsDP15MITm+OND3LLSg9Jxz8LOYs6enLxy7OmFIJF685XDhtDdvGSVCbdB4Ndhygw8HiDxnZ hh4ByX+N/v60g3IdoFXc7v8GIDMTtSukOwKlm44jENcFZBjjC518OH1ugLcbnR/f+vT9L7tO fDNahD1nrLNsOtZKkW1Ieztl7EEz8IUZzjMqXuEWSEZn0luE8j6FnuTr1JId8WL9AqM/vcVY /UN8v4d4bUvjQ2+k0U3aMsumw+Y5PUsiFfy+gLkCDQRaIcDTARAAwhbtQAUmZG/rkpR/6/xr 7jRqi5Z3M5LZNw4lW9k4nBpQDAP/rLVuREnz/upm314P9i5iN9g2wsbReZBJ9KiUxT39KD5p 99KZGIH0elgZy+nDnb3oQLbtAr8+ox1ThOyOEJ7iX378txc1JD9IWJuv6YLMlkXa4ZuuAMCq KUvCChEjcHhZ+Ecb8OX8GwIKUoklWhoHR7OcMqAkjdhA698FkWNkgIeqMiTN/hBJ9u010ZeB 82ibDAKSMetMRxflCwThrVrfrOr5+ZkJvoN5r+Jy1ulk8OOnDOjvqXoUcee5zdloZymeY3f7 zebddvPmuiR0qXX0KYeSbhNF1GugLgbYeU2ev0nZ74F6vTwLUraRjKUzk0bq6SELlNMriS2x Wj7zDB2XtzUdTHPYSgFDKGYxRqiM7KJbheCL7gD1wxUGRf14yJISXmDX/fZhsFrZ/NF3UqxJ nLCz9lqyMCvT8prJjlAQu0zcFcrGAYVBNeJMAKlukMllRMgWdSLmJQiDC5JMaXoEeXdGpIv8 LgH+yU3tkKjXvkjwGywcXuL28ZScap3iJj08B8HWHmlL5b3pCkZv1w87SSF+FarrWl4F4u4U j+u2r7/NEZVmJ0GpNHNwkYFQiX1Coky6+Ga1/gXUBP6grI9eZOMD+qtsJC1JVPY8VIsjq/47 R1tBTKoiANQ/M+MAEQEAAYkCPAQYAQgAJgIbDBYhBOsseT4wTbhgdqiVxvDh9yYlivj1BQJh WuePBQkae8fdAAoJEPDh9yYlivj1GmsP/AwKF5WPyg3M1e7YPAYc3vsp2RQccnIjQ62MYxbz VWFs32GT0FyeIBzzT5aaVNyWzumNSyp51LC29AeqL/LXel9bUCzg3v0g5UutXAh9XYnWvgD6 12U4WlFUPmSVKz7B1kf9fwFfOUyRnT1Ayf91GDW9vTP2yWboXqelQdawa1Wl7G+C+unyuu3q OoPkNu65g6ZanO66ycXz6BDOlfCP7WPhcdyi85PuaJhXGbOysKS/m+tptS7XStqp+9Hvj1pj 3pajr5Nktufg3+QLQTj7iUowMnHdClY5d5c34gayzXHIZw9pSM4u4NStEGUTHk9JVRNd09A0 J3PzCngz9isv6Cdi7dZH4ivjOqXnD3Wq6Dwmu2RaBciQx8fuM58o6VBQ2cQa00QRT96UPWph G5BEGryzI0IxAmQtNDwneJx+jscGmMWvm4PkTViBnRcJtlJVO0lR5tWjscVG4TgBIo1M5qmi t0GfVUkS4E8AhVNtPG1Z5vl7JkfX3irc4ld58j1STfhLuos5l4X+7lRncpbYCsuk9rz1Bjh8 r/bUbqMkpj7m27JXi7cHIOtZ4up9O0O8WFdPpLRmy6GS67czo5dpV3CowY9LtZ0+0JmnUd59 kutl2mu4Qd3cGFbZB4J8J3p+wtsx7bujP38lQvmqpyGTUtyoGO9nOL0X5Xi95CAqapnE Message-ID: <635357ce-8793-1788-e47e-369ed8ded673@mailbox.org> Date: Fri, 7 Apr 2023 13:56:49 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-MBO-RS-META: 9durk4ohq9xzbiw5udisk8a8no5irb91 X-MBO-RS-ID: bb264dcb417217733be Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Am 06.04.23 um 22:09 schrieb Greg KH: > On Thu, Apr 06, 2023 at 05:39:07PM +0200, Rainer Fiebig wrote: >> Am 06.04.23 um 15:30 schrieb Linux regression tracking (Thorsten Leemhuis): >>> [CCing the regression list, as it should be in the loop for regressions: >>> https://docs.kernel.org/admin-guide/reporting-regressions.html] >>> >>> On 06.04.23 14:06, Rainer Fiebig wrote: >>>> Hi! Since kernel 6.1.22 starting a resume from hibernate by hitting a >>>> key on the keyboard fails. However, if the PC was switched off and on >>>> again (or reset), the resume is OK. The APU is a Ryzen 5600G. >>>> >>>> Bisecting between 6.1.21/22 turned up this: >>>> >>>> >>>> Author: Tim Huang >>>> Date: Thu Mar 9 16:27:51 2023 +0800 >>>> >>>> drm/amdgpu: skip ASIC reset for APUs when go to S4 >>>> >>>> commit b589626674de94d977e81c99bf7905872b991197 upstream. >>>> >>>> For GC IP v11.0.4/11, PSP TMR need to be reserved >>>> for ASIC mode2 reset. But for S4, when psp suspend, >>>> it will destroy the TMR that fails the ASIC reset. >>>> [...] >>>> >>>> >>>> Reverting the commit solves the problem. >>>> Thanks. >>> >>> Please try 6.1.23 and report back, because from the thread >>> https://lore.kernel.org/all/20230330160740.1dbff94b@schienar/ >>> it sounds a lot like "drm/amdgpu: allow more APUs to do mode2 reset when >>> go to S4" might be fixing this, which went into 6.1.23. >> Yes, 6.1.23 seems OK so far. >> >> I think, however, that rc-kernels and LTS-kernels are different matters. >> With a bleeding edge kernel, problems are to be expected. But an >> LTS-kernel is chosen for stability. And this is the second time within >> just a few weeks that I've been bitten by a time-consuming hibernate-bug >> caused by a backport of a commit in amdgpu. >> >> So I'm asking the devs to either test their patches more thoroughly or >> to be a bit more conservative with what they recommend for backporting >> to LTS-kernels. Thanks. > > Please feel free to suggest better ways to have automated tests for > stuff like this, or to help provide testing for the -rc LTS/stable > kernel releases. Well, I'm afraid I can't offer a panacea or the ultimate automated quality assurance system. But for the two cases that I've encountered lately, a simple hibernate/resume would have shown that there's a problem. After all, that's how I and other users noticed it. So I think the primary line of defence against regressions remains the developer himself who should try hard to imagine what ramifications his patch might have and test it accordingly. But I'm aware of the fact that we are all only humans. Another idea might be to give patches that introduce new features or only minimal improvements ample time to mature in the latest stable kernel before backporting them to LTS-kernels, say three or four point-releases. Or to only backport fixes for bugs or security issues. > > We can't do this alone :) Right. For now I can't commit to testing release-candidates because of a lack in time. But I try to bisect and report problems as soon as possible so that they can be resolved quickly. To avoid a false impression: kernelwise - and including amdgpu - I'm rather happy with the current state of affairs. Thanks to all! Rainer Fiebig