From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58950345CAB for ; Tue, 14 Apr 2026 06:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776147769; cv=none; b=hElyJk5rQGCnyPE3K9LHgiNf5UrZBjJlT2e+WumKBEj8riwYm5fsq3Lbz0+ven5DEsCHK1LQ7iFtmGQsqHVr9jZzlLsWXsGmFlyggxK6khTZb8ZqD9GOk6w/mL5WTNrxMp9MnmHaYKYR2LfYa//ttPdlNHPG9+S85GFeRgpwlHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776147769; c=relaxed/simple; bh=nKm0GbVKCHtHP0hrVGkVDigPvP6pst7c01jVOvopZME=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=al++lvWUOeijMuqTw6p0ixjR7Mk86ljyoT3LoG6RMRRNN7j9cFCdA/dz1BIgTb6L/BfRge6CgPetKbjTCV4FSDII6SAVq13cdTstvFfz/nX1Oi7+gTVhZrt7aEPlkZLhAdjjp5tKQvEcPEiUlNylXcwP4dHwsoH5p/CIV2aL8yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jvuX0ikd; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jvuX0ikd" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-671dad7cac8so648359a12.0 for ; Mon, 13 Apr 2026 23:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776147764; x=1776752564; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=i7FXQ2tntyeG1C8OQfk9LnQuBp6YLBRP1mkqDhPOgr4=; b=jvuX0ikdIcfAJ8/iWbp9DgtWA2eBYzefwuygte4IUUz68hKbynEzX6357Y6U0QJAJ9 Zu7UKzSBDaMj2BW9M0pqOeH7MktNq6XsMMc3kb8nMJdjVHylP1846mUUtcmgl9StC7Y2 VvqWWddvUBYu4GQr6sxAm1MIF0XisHb+nWFjETnXJRlEAFVr1EXlN0vQt9KSlIXmHpRP cthA6I2zYi8wkCuK0hK+acvFf5u+mZssriTKlCwHnt6rGJ1JnD8xFMUllBvDjohbDJKY jAYrX8sotrAI4Ew0C2Chn2wpmzesWGUu5cWygiMG0w0+C9hAY6IoBsB7cHIXexd3adgg UteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776147764; x=1776752564; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i7FXQ2tntyeG1C8OQfk9LnQuBp6YLBRP1mkqDhPOgr4=; b=WaAYaAaNCf/TN7frfO/rzQvSnc+HFym5e6Owdiwbky1AFD9DDO3wevuYTtNs5AGlhh 9n9hVea9ibPqGW2U849mQen0qt4GwMy/hcfew/by4Ydhv1sBPEmU8aBOpu3LTBvSy9tz xEJEEsKfGdd0+6k48ywDueq64UBlstfTZhVVQpGPDOteBj0Axuuf5QeHh/1yFpg+xlc2 mKNFc0UjePu3AwFTMS7zQv2RDQi9yQhVo9Tl0Cu0o8DonouSLK0cy5V6Ittp1gFiBe7D GbLtkPSdY9KY1cqQRmVdoNG5oa+x5EpA9FmXZX59GY/161jQLhxbAlzQG35au3MbGqgw 0BjA== X-Forwarded-Encrypted: i=1; AFNElJ8lc7/eusn4u+T2MtUFnGm+1b/DvdmSM1mbKvJO1ONgBmsL6Ls+SwLDCOJH5Rhi4RTpfRCXGmg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/MQqUc7f1irqC+ZZcRCkV7YG44J1ChG+pNLFqGLZS2ysPmNQq F/r5epGP6YdbqI41f61Bg/FaAWet7PbQ2rhhnuNXfVZPSr/V+gGXcWHS X-Gm-Gg: AeBDietyDfcfF3FHsM3VU+dAdvJBBbaEzFh41ttIcvAz+rbWF1EKXy/85rWCh6PFEk0 B5sdEHCQwTfGYF/oiN20Aj5YgtsGXD6dhsNkiqyzi+UfRedaJ8zxyBxjwigmVJOyBdTktZbhGK9 Uyohev2ho8ysBKEFWw7+0fShLABNCILjDYnQR94Kq4MzRBcGhLzcjijDlsYWAmuzxxbAfeJQAOu f15syPcjf7rEErRHCIUo4uNU/amKzLW1AD68pVW+AkIjdNWDPV+GEcIai6PIq91Vvm9VndIT5sM /pi21SnL6Kv5FZd1rZoys2OJkvbroj/ruyvJE04O8w3a1PNqV2otWxwbV9RXAmjJiAQGxcLtUJj mM2LiHgsyLke4HiIvjo3PJuZdpCkdfbUn28PByFZym+UkkqD6jlCj375K7mzM0SPGw64WHdcsw5 yI6y/xacnZchYKyzwpCM+4k6YNN850MoWPs6wRTTYZccf0wjPulJJWxz4zvqEVbDIc+ckHfG3Ig wVbdAP3GU5wt35LcdovVTUPz4rDiW0Z4pS3ium+w5q68XSFYTJNL1IiRjh8cw== X-Received: by 2002:a17:907:c20:b0:b9c:b7c7:8a7f with SMTP id a640c23a62f3a-b9d7249947emr910336566b.1.1776147763849; Mon, 13 Apr 2026 23:22:43 -0700 (PDT) Received: from ahossu.localdomain ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e5c582fsm385453366b.31.2026.04.13.23.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:22:43 -0700 (PDT) Message-ID: <69dddd33.170a0220.e92ec.d295@mx.google.com> Date: Mon, 13 Apr 2026 23:22:43 -0700 (PDT) Content-Type: multipart/mixed; boundary="===============3219866366644994571==" Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Alexandru Hossu To: dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, hansg@kernel.org, stable@vger.kernel.org, hossu.alexandru@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: fix heap overflow in OnAuthClient shared key path In-Reply-To: <20260413202824.740653-1-hossu.alexandru@gmail.com> References: <20260413202824.740653-1-hossu.alexandru@gmail.com> --===============3219866366644994571== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Tue, Apr 14, 2026 at 08:19:00AM +0000, Dan Carpenter wrote: > Looks good. > > Reviewed-by: Dan Carpenter > > p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&len, > ^^^^^^ > Do we know that pframe has enough data? > > KTODO: check if pframe is large enough in OnAuthClient() Good catch. There's no minimum length check before the subtraction, so a frame shorter than WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_ (30 bytes) would cause pkt_len to underflow since it's unsigned. I'll send a follow-up patch adding the check. Thanks for the review. Alexandru --===============3219866366644994571==--