From: David Ahern <dsahern@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>, Hyunwoo Kim <imv4bel@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
kuba@kernel.org, steffen.klassert@secunet.com,
netdev@vger.kernel.org, stable@vger.kernel.org, mhal@rbox.co,
davem@davemloft.net, horms@kernel.org, edumazet@google.com,
kerneljasonxing@gmail.com, herbert@gondor.apana.org.au,
vakzz@zellic.io, kuniyu@google.com, jiayuan.chen@linux.dev,
ben@decadent.org.uk
Subject: Re: [PATCH net v2] net: skbuff: propagate shared-frag marker through frag-transfer helpers
Date: Thu, 14 May 2026 08:37:19 -0600 [thread overview]
Message-ID: <69f72d09-8054-4d26-b277-9e9b7a8854c1@kernel.org> (raw)
In-Reply-To: <agWiDlvu351MSuqO@krikkit>
On 5/14/26 4:21 AM, Sabrina Dubroca wrote:
> 2026-05-14, 18:38:34 +0900, Hyunwoo Kim wrote:
>> On Thu, May 14, 2026 at 10:04:29AM +0200, Paolo Abeni wrote:
>>> On 5/13/26 11:07 PM, Hyunwoo Kim wrote:
>> Agreed. tracing SKBFL_SHARED_FRAG propagation paths one by one is
>> not a robust direction for the fix. Even minor logic changes elsewhere
>> could cause the issue to resurface.
>>
>> As a follow-up, eliminating the in-place handling in esp_input -- accepting
>
> It would close this group of vulnerabilities, but there are other
> parts of the networking stack that consume this flag. For those,
> chasing missing flag propagation is still a useful task.
>
Seems like this should be an skb helper to manage the flag with really
good documentation on when it needs to be set, reset and propagated.
I walked skbuff.c yesterday as well, and there are several places where
it is not clear if the flag needs to be propagated or not.
next prev parent reply other threads:[~2026-05-14 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 21:07 [PATCH net v2] net: skbuff: propagate shared-frag marker through frag-transfer helpers Hyunwoo Kim
2026-05-14 6:18 ` Sultan Alsawaf
2026-05-14 9:23 ` Hyunwoo Kim
2026-05-14 8:04 ` Paolo Abeni
2026-05-14 9:38 ` Hyunwoo Kim
2026-05-14 10:21 ` Sabrina Dubroca
2026-05-14 14:37 ` David Ahern [this message]
2026-05-14 15:45 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69f72d09-8054-4d26-b277-9e9b7a8854c1@kernel.org \
--to=dsahern@kernel.org \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=imv4bel@gmail.com \
--cc=jiayuan.chen@linux.dev \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=vakzz@zellic.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox