From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pg0-f66.google.com ([74.125.83.66]:43982 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751183AbeEERWM (ORCPT
        <rfc822;stable@vger.kernel.org>); Sat, 5 May 2018 13:22:12 -0400
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] compiler-gcc: disable -ftracer for __noclone functions
From: Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <1459410252-15531-1-git-send-email-pbonzini@redhat.com>
Date: Sat, 5 May 2018 10:22:10 -0700
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>, lkml@tlinx.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Marek <mmarek@suse.cz>, stable@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6BAD64FE-CC59-40C3-9C42-90BB8EEE5453@gmail.com>
References: <1459410252-15531-1-git-send-email-pbonzini@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Paolo Bonzini <pbonzini@redhat.com> wrote:

> -ftracer can duplicate asm blocks causing compilation to fail in
> noclone functions.  For example, KVM declares a global variable
> in an asm like
>=20
>    asm("2: ... \n
>         .pushsection data \n
>         .global vmx_return \n
>         vmx_return: .long 2b");
>=20
> and -ftracer causes a double declaration.
>=20
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: stable@vger.kernel.org
> Cc: kvm@vger.kernel.org
> Reported-by: Linda Walsh <lkml@tlinx.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/linux/compiler-gcc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/linux/compiler-gcc.h =
b/include/linux/compiler-gcc.h
> index 22ab246feed3..eeae401a2412 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -199,7 +199,7 @@
> #define unreachable() __builtin_unreachable()
>=20
> /* Mark a function definition as prohibited from being cloned. */
> -#define __noclone	__attribute__((__noclone__))
> +#define __noclone	__attribute__((__noclone__, =
__optimize__("no-tracer")))

[ Bringing the thread back from the dead for context ]

Setting different optimization attributes to certain functions =
apparently
prevents gcc from inlining functions with different =E2=80=9Coptimizations=
=E2=80=9D. This
results in poor compilation - most notably of vmx_vcpu_run() - and =
causes
short functions such as to_vmx() not to be inlined.

Regards,
Nadav=