public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Vishnu Rangayyan <vishnu.rangayyan@apple.com>
To: stable@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Andrew Forgue <andrewf@apple.com>
Subject: Fixes for 4.19 stable
Date: Fri, 28 Feb 2020 12:13:54 -0800	[thread overview]
Message-ID: <6CF798B4-B68B-4729-A496-2152FC032ABC@apple.com> (raw)

Hi,

I still see high (upto 30%) ksoftirqd cpu use with 4.19.101+ after these 2 back ports went in for 4.19.101
(had all 4 backports applied earlier to our tree):

commit f6783319737f28e4436a69611853a5a098cbe974 sched/fair: Fix insertion in rq->leaf_cfs_rq_list
commit 5d299eabea5a251fbf66e8277704b874bbba92dc sched/fair: Add tmp_alone_branch assertion

perf shows for any given ksoftirqd, with 20k-30k processes on the system with high scheduler load:
  58.88%  ksoftirqd/0  [kernel.kallsyms]  [k] update_blocked_averages

Can we backport these 2 also, confirmed that it fixes this behavior of ksoftirqd.

commit 039ae8bcf7a5f4476f4487e6bf816885fb3fb617 upstream
commit 31bc6aeaab1d1de8959b67edbed5c7a4b3cdbe7c upstream

The second one doesn’t apply cleanly, there’s a small change for the last diff, where pelt needs renaming to task (cfg_rq_clock_pelt was cfs_rq_clock_task in 4.19.y) in that unchanged part of the diff:

@@ -7700,10 +7720,6 @@ static void update_blocked_averages(int cpu)
 	for_each_leaf_cfs_rq(rq, cfs_rq) {
 		struct sched_entity *se;
 
-		/* throttled entities do not contribute to load */
-		if (throttled_hierarchy(cfs_rq))
-			continue;
-
 		if (update_cfs_rq_load_avg(cfs_rq_clock_pelt(cfs_rq), cfs_rq))
 			update_tg_load_avg(cfs_rq, 0);


I can post that patch with that rename if required.

Thanks 
Vishnu


             reply	other threads:[~2020-02-29  5:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 20:13 Vishnu Rangayyan [this message]
2020-03-01  3:11 ` Fixes for 4.19 stable Sasha Levin
2020-03-02 23:13   ` Vishnu Rangayyan
2020-03-03  8:03     ` Vincent Guittot
2020-03-03 15:43       ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6CF798B4-B68B-4729-A496-2152FC032ABC@apple.com \
    --to=vishnu.rangayyan@apple.com \
    --cc=andrewf@apple.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox