Re: [PATCH v4 4/4] ASoC: wm8994: drain delayed works on remove and probe error

[Tristan Madani <tristmd@gmail.com>]

On Mon, 2 Nov 2026 at 09:51:32 +0000, Charles Keepax wrote:
> Both paths appears to cancel the mic_work twice?

Yes, intentional.  wm1811_mic_work() can re-arm jackdet_bootstrap
through the DAPM power-up chain (force-enabling MICBIAS2 triggers
clk_sys_event which queues jackdet_bootstrap), and
wm1811_jackdet_bootstrap() ultimately queues mic_work back.

So the sequence is:

  1. cancel mic_work           -- drain whatever is pending
  2. cancel jackdet_bootstrap  -- drain; if its handler was in flight
                                  during (1) it may have re-queued
                                  mic_work
  3. cancel mic_work           -- catch that re-arm

Without the second mic_work cancel, a jackdet_bootstrap handler
running concurrently with step 1 can slip a mic_work re-queue in
between steps 1 and 2, and that work fires after resources are freed.

Thanks,
Tristan