* [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup
[not found] <20171120104547.2639-1-johan@kernel.org>
@ 2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:33 ` Daniel Thompson
2017-11-29 11:28 ` Lee Jones
2017-11-20 10:45 ` [PATCH v2 2/4] backlight: max8925_bl: " Johan Hovold
2017-11-20 10:45 ` [PATCH v2 3/4] backlight: tps65217_bl: " Johan Hovold
2 siblings, 2 replies; 10+ messages in thread
From: Johan Hovold @ 2017-11-20 10:45 UTC (permalink / raw)
To: Lee Jones
Cc: Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel, Johan Hovold, stable,
Guennadi Liakhovetski
Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.
To make things worse, the parent mfd node was also prematurely freed.
Fixes: 59eb2b5e57ea ("drivers/video/backlight/as3711_bl.c: add OF support")
Cc: stable <stable@vger.kernel.org> # 3.10
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/video/backlight/as3711_bl.c | 33 +++++++++++++++++++++++----------
1 file changed, 23 insertions(+), 10 deletions(-)
diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c
index 734a9158946b..e55304d5cf07 100644
--- a/drivers/video/backlight/as3711_bl.c
+++ b/drivers/video/backlight/as3711_bl.c
@@ -262,10 +262,10 @@ static int as3711_bl_register(struct platform_device *pdev,
static int as3711_backlight_parse_dt(struct device *dev)
{
struct as3711_bl_pdata *pdata = dev_get_platdata(dev);
- struct device_node *bl =
- of_find_node_by_name(dev->parent->of_node, "backlight"), *fb;
+ struct device_node *bl, *fb;
int ret;
+ bl = of_get_child_by_name(dev->parent->of_node, "backlight");
if (!bl) {
dev_dbg(dev, "backlight node not found\n");
return -ENODEV;
@@ -279,7 +279,7 @@ static int as3711_backlight_parse_dt(struct device *dev)
if (pdata->su1_max_uA <= 0)
ret = -EINVAL;
if (ret < 0)
- return ret;
+ goto err_put_bl;
}
fb = of_parse_phandle(bl, "su2-dev", 0);
@@ -292,7 +292,7 @@ static int as3711_backlight_parse_dt(struct device *dev)
if (pdata->su2_max_uA <= 0)
ret = -EINVAL;
if (ret < 0)
- return ret;
+ goto err_put_bl;
if (of_find_property(bl, "su2-feedback-voltage", NULL)) {
pdata->su2_feedback = AS3711_SU2_VOLTAGE;
@@ -314,8 +314,10 @@ static int as3711_backlight_parse_dt(struct device *dev)
pdata->su2_feedback = AS3711_SU2_CURR_AUTO;
count++;
}
- if (count != 1)
- return -EINVAL;
+ if (count != 1) {
+ ret = -EINVAL;
+ goto err_put_bl;
+ }
count = 0;
if (of_find_property(bl, "su2-fbprot-lx-sd4", NULL)) {
@@ -334,8 +336,10 @@ static int as3711_backlight_parse_dt(struct device *dev)
pdata->su2_fbprot = AS3711_SU2_GPIO4;
count++;
}
- if (count != 1)
- return -EINVAL;
+ if (count != 1) {
+ ret = -EINVAL;
+ goto err_put_bl;
+ }
count = 0;
if (of_find_property(bl, "su2-auto-curr1", NULL)) {
@@ -355,11 +359,20 @@ static int as3711_backlight_parse_dt(struct device *dev)
* At least one su2-auto-curr* must be specified iff
* AS3711_SU2_CURR_AUTO is used
*/
- if (!count ^ (pdata->su2_feedback != AS3711_SU2_CURR_AUTO))
- return -EINVAL;
+ if (!count ^ (pdata->su2_feedback != AS3711_SU2_CURR_AUTO)) {
+ ret = -EINVAL;
+ goto err_put_bl;
+ }
}
+ of_node_put(bl);
+
return 0;
+
+err_put_bl:
+ of_node_put(bl);
+
+ return ret;
}
static int as3711_backlight_probe(struct platform_device *pdev)
--
2.15.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup
2017-11-20 10:45 ` [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup Johan Hovold
@ 2017-11-20 11:33 ` Daniel Thompson
2017-11-29 11:28 ` Lee Jones
1 sibling, 0 replies; 10+ messages in thread
From: Daniel Thompson @ 2017-11-20 11:33 UTC (permalink / raw)
To: Johan Hovold, Lee Jones
Cc: Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
linux-kernel, stable, Guennadi Liakhovetski
On 20/11/17 10:45, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> To make things worse, the parent mfd node was also prematurely freed.
>
> Fixes: 59eb2b5e57ea ("drivers/video/backlight/as3711_bl.c: add OF support")
> Cc: stable <stable@vger.kernel.org> # 3.10
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/as3711_bl.c | 33 +++++++++++++++++++++++----------
> 1 file changed, 23 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c
> index 734a9158946b..e55304d5cf07 100644
> --- a/drivers/video/backlight/as3711_bl.c
> +++ b/drivers/video/backlight/as3711_bl.c
> @@ -262,10 +262,10 @@ static int as3711_bl_register(struct platform_device *pdev,
> static int as3711_backlight_parse_dt(struct device *dev)
> {
> struct as3711_bl_pdata *pdata = dev_get_platdata(dev);
> - struct device_node *bl =
> - of_find_node_by_name(dev->parent->of_node, "backlight"), *fb;
> + struct device_node *bl, *fb;
> int ret;
>
> + bl = of_get_child_by_name(dev->parent->of_node, "backlight");
> if (!bl) {
> dev_dbg(dev, "backlight node not found\n");
> return -ENODEV;
> @@ -279,7 +279,7 @@ static int as3711_backlight_parse_dt(struct device *dev)
> if (pdata->su1_max_uA <= 0)
> ret = -EINVAL;
> if (ret < 0)
> - return ret;
> + goto err_put_bl;
> }
>
> fb = of_parse_phandle(bl, "su2-dev", 0);
> @@ -292,7 +292,7 @@ static int as3711_backlight_parse_dt(struct device *dev)
> if (pdata->su2_max_uA <= 0)
> ret = -EINVAL;
> if (ret < 0)
> - return ret;
> + goto err_put_bl;
>
> if (of_find_property(bl, "su2-feedback-voltage", NULL)) {
> pdata->su2_feedback = AS3711_SU2_VOLTAGE;
> @@ -314,8 +314,10 @@ static int as3711_backlight_parse_dt(struct device *dev)
> pdata->su2_feedback = AS3711_SU2_CURR_AUTO;
> count++;
> }
> - if (count != 1)
> - return -EINVAL;
> + if (count != 1) {
> + ret = -EINVAL;
> + goto err_put_bl;
> + }
>
> count = 0;
> if (of_find_property(bl, "su2-fbprot-lx-sd4", NULL)) {
> @@ -334,8 +336,10 @@ static int as3711_backlight_parse_dt(struct device *dev)
> pdata->su2_fbprot = AS3711_SU2_GPIO4;
> count++;
> }
> - if (count != 1)
> - return -EINVAL;
> + if (count != 1) {
> + ret = -EINVAL;
> + goto err_put_bl;
> + }
>
> count = 0;
> if (of_find_property(bl, "su2-auto-curr1", NULL)) {
> @@ -355,11 +359,20 @@ static int as3711_backlight_parse_dt(struct device *dev)
> * At least one su2-auto-curr* must be specified iff
> * AS3711_SU2_CURR_AUTO is used
> */
> - if (!count ^ (pdata->su2_feedback != AS3711_SU2_CURR_AUTO))
> - return -EINVAL;
> + if (!count ^ (pdata->su2_feedback != AS3711_SU2_CURR_AUTO)) {
> + ret = -EINVAL;
> + goto err_put_bl;
> + }
> }
>
> + of_node_put(bl);
> +
> return 0;
> +
> +err_put_bl:
> + of_node_put(bl);
> +
> + return ret;
> }
>
> static int as3711_backlight_probe(struct platform_device *pdev)
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup
2017-11-20 10:45 ` [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup Johan Hovold
2017-11-20 11:33 ` Daniel Thompson
@ 2017-11-29 11:28 ` Lee Jones
1 sibling, 0 replies; 10+ messages in thread
From: Lee Jones @ 2017-11-29 11:28 UTC (permalink / raw)
To: Johan Hovold
Cc: Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel, stable, Guennadi Liakhovetski
On Mon, 20 Nov 2017, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> To make things worse, the parent mfd node was also prematurely freed.
>
> Fixes: 59eb2b5e57ea ("drivers/video/backlight/as3711_bl.c: add OF support")
> Cc: stable <stable@vger.kernel.org> # 3.10
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/video/backlight/as3711_bl.c | 33 +++++++++++++++++++++++----------
> 1 file changed, 23 insertions(+), 10 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/4] backlight: max8925_bl: fix device-tree node lookup
[not found] <20171120104547.2639-1-johan@kernel.org>
2017-11-20 10:45 ` [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup Johan Hovold
@ 2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:33 ` Daniel Thompson
2017-11-29 11:29 ` Lee Jones
2017-11-20 10:45 ` [PATCH v2 3/4] backlight: tps65217_bl: " Johan Hovold
2 siblings, 2 replies; 10+ messages in thread
From: Johan Hovold @ 2017-11-20 10:45 UTC (permalink / raw)
To: Lee Jones
Cc: Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel, Johan Hovold, stable, Qing Xu,
Haojian Zhuang
Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.
To make things worse, the parent mfd node was also prematurely freed,
while the child backlight node was leaked.
Fixes: 47ec340cb8e2 ("mfd: max8925: Support dt for backlight")
Cc: stable <stable@vger.kernel.org> # 3.9
Cc: Qing Xu <qingx@marvell.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/video/backlight/max8925_bl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/max8925_bl.c b/drivers/video/backlight/max8925_bl.c
index 7b738d60ecc2..f3aa6088f1d9 100644
--- a/drivers/video/backlight/max8925_bl.c
+++ b/drivers/video/backlight/max8925_bl.c
@@ -116,7 +116,7 @@ static void max8925_backlight_dt_init(struct platform_device *pdev)
if (!pdata)
return;
- np = of_find_node_by_name(nproot, "backlight");
+ np = of_get_child_by_name(nproot, "backlight");
if (!np) {
dev_err(&pdev->dev, "failed to find backlight node\n");
return;
@@ -125,6 +125,8 @@ static void max8925_backlight_dt_init(struct platform_device *pdev)
if (!of_property_read_u32(np, "maxim,max8925-dual-string", &val))
pdata->dual_string = val;
+ of_node_put(np);
+
pdev->dev.platform_data = pdata;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/4] backlight: max8925_bl: fix device-tree node lookup
2017-11-20 10:45 ` [PATCH v2 2/4] backlight: max8925_bl: " Johan Hovold
@ 2017-11-20 11:33 ` Daniel Thompson
2017-11-29 11:29 ` Lee Jones
1 sibling, 0 replies; 10+ messages in thread
From: Daniel Thompson @ 2017-11-20 11:33 UTC (permalink / raw)
To: Johan Hovold, Lee Jones
Cc: Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
linux-kernel, stable, Qing Xu, Haojian Zhuang
On 20/11/17 10:45, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> To make things worse, the parent mfd node was also prematurely freed,
> while the child backlight node was leaked.
>
> Fixes: 47ec340cb8e2 ("mfd: max8925: Support dt for backlight")
> Cc: stable <stable@vger.kernel.org> # 3.9
> Cc: Qing Xu <qingx@marvell.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Didn't I already ack this one?
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/max8925_bl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/max8925_bl.c b/drivers/video/backlight/max8925_bl.c
> index 7b738d60ecc2..f3aa6088f1d9 100644
> --- a/drivers/video/backlight/max8925_bl.c
> +++ b/drivers/video/backlight/max8925_bl.c
> @@ -116,7 +116,7 @@ static void max8925_backlight_dt_init(struct platform_device *pdev)
> if (!pdata)
> return;
>
> - np = of_find_node_by_name(nproot, "backlight");
> + np = of_get_child_by_name(nproot, "backlight");
> if (!np) {
> dev_err(&pdev->dev, "failed to find backlight node\n");
> return;
> @@ -125,6 +125,8 @@ static void max8925_backlight_dt_init(struct platform_device *pdev)
> if (!of_property_read_u32(np, "maxim,max8925-dual-string", &val))
> pdata->dual_string = val;
>
> + of_node_put(np);
> +
> pdev->dev.platform_data = pdata;
> }
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/4] backlight: max8925_bl: fix device-tree node lookup
2017-11-20 10:45 ` [PATCH v2 2/4] backlight: max8925_bl: " Johan Hovold
2017-11-20 11:33 ` Daniel Thompson
@ 2017-11-29 11:29 ` Lee Jones
1 sibling, 0 replies; 10+ messages in thread
From: Lee Jones @ 2017-11-29 11:29 UTC (permalink / raw)
To: Johan Hovold
Cc: Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel, stable, Qing Xu, Haojian Zhuang
On Mon, 20 Nov 2017, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> To make things worse, the parent mfd node was also prematurely freed,
> while the child backlight node was leaked.
>
> Fixes: 47ec340cb8e2 ("mfd: max8925: Support dt for backlight")
> Cc: stable <stable@vger.kernel.org> # 3.9
> Cc: Qing Xu <qingx@marvell.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/video/backlight/max8925_bl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup
[not found] <20171120104547.2639-1-johan@kernel.org>
2017-11-20 10:45 ` [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup Johan Hovold
2017-11-20 10:45 ` [PATCH v2 2/4] backlight: max8925_bl: " Johan Hovold
@ 2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:34 ` Daniel Thompson
2017-11-29 11:29 ` Lee Jones
2 siblings, 2 replies; 10+ messages in thread
From: Johan Hovold @ 2017-11-20 10:45 UTC (permalink / raw)
To: Lee Jones
Cc: Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel, Johan Hovold, stable,
Matthias Kaehlcke
Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.
This would only cause trouble if the child node is missing while there
is an unrelated node named "backlight" elsewhere in the tree.
Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
Cc: stable <stable@vger.kernel.org> # 3.7
Cc: Matthias Kaehlcke <matthias@kaehlcke.net>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/video/backlight/tps65217_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c
index 380917c86276..762e3feed097 100644
--- a/drivers/video/backlight/tps65217_bl.c
+++ b/drivers/video/backlight/tps65217_bl.c
@@ -184,11 +184,11 @@ static struct tps65217_bl_pdata *
tps65217_bl_parse_dt(struct platform_device *pdev)
{
struct tps65217 *tps = dev_get_drvdata(pdev->dev.parent);
- struct device_node *node = of_node_get(tps->dev->of_node);
+ struct device_node *node;
struct tps65217_bl_pdata *pdata, *err;
u32 val;
- node = of_find_node_by_name(node, "backlight");
+ node = of_get_child_by_name(tps->dev->of_node, "backlight");
if (!node)
return ERR_PTR(-ENODEV);
--
2.15.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup
2017-11-20 10:45 ` [PATCH v2 3/4] backlight: tps65217_bl: " Johan Hovold
@ 2017-11-20 11:34 ` Daniel Thompson
2017-11-20 11:44 ` Johan Hovold
2017-11-29 11:29 ` Lee Jones
1 sibling, 1 reply; 10+ messages in thread
From: Daniel Thompson @ 2017-11-20 11:34 UTC (permalink / raw)
To: Johan Hovold, Lee Jones
Cc: Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
linux-kernel, stable, Matthias Kaehlcke
On 20/11/17 10:45, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> This would only cause trouble if the child node is missing while there
> is an unrelated node named "backlight" elsewhere in the tree.
>
> Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
> Cc: stable <stable@vger.kernel.org> # 3.7
> Cc: Matthias Kaehlcke <matthias@kaehlcke.net>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Didn't I already ack this one?
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/tps65217_bl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c
> index 380917c86276..762e3feed097 100644
> --- a/drivers/video/backlight/tps65217_bl.c
> +++ b/drivers/video/backlight/tps65217_bl.c
> @@ -184,11 +184,11 @@ static struct tps65217_bl_pdata *
> tps65217_bl_parse_dt(struct platform_device *pdev)
> {
> struct tps65217 *tps = dev_get_drvdata(pdev->dev.parent);
> - struct device_node *node = of_node_get(tps->dev->of_node);
> + struct device_node *node;
> struct tps65217_bl_pdata *pdata, *err;
> u32 val;
>
> - node = of_find_node_by_name(node, "backlight");
> + node = of_get_child_by_name(tps->dev->of_node, "backlight");
> if (!node)
> return ERR_PTR(-ENODEV);
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup
2017-11-20 11:34 ` Daniel Thompson
@ 2017-11-20 11:44 ` Johan Hovold
0 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2017-11-20 11:44 UTC (permalink / raw)
To: Daniel Thompson
Cc: Johan Hovold, Lee Jones, Jingoo Han, Bartlomiej Zolnierkiewicz,
dri-devel, linux-fbdev, linux-kernel, stable, Matthias Kaehlcke
On Mon, Nov 20, 2017 at 11:34:07AM +0000, Daniel Thompson wrote:
>
>
> On 20/11/17 10:45, Johan Hovold wrote:
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at the parent rather than just matching
> > on its children.
> >
> > This would only cause trouble if the child node is missing while there
> > is an unrelated node named "backlight" elsewhere in the tree.
> >
> > Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
> > Cc: stable <stable@vger.kernel.org> # 3.7
> > Cc: Matthias Kaehlcke <matthias@kaehlcke.net>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Didn't I already ack this one?
Indeed you did (same with the previous one). Sorry about forgetting to
add them to v2.
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks for the acks.
Johan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup
2017-11-20 10:45 ` [PATCH v2 3/4] backlight: tps65217_bl: " Johan Hovold
2017-11-20 11:34 ` Daniel Thompson
@ 2017-11-29 11:29 ` Lee Jones
1 sibling, 0 replies; 10+ messages in thread
From: Lee Jones @ 2017-11-29 11:29 UTC (permalink / raw)
To: Johan Hovold
Cc: Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-kernel, stable, Matthias Kaehlcke
On Mon, 20 Nov 2017, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> This would only cause trouble if the child node is missing while there
> is an unrelated node named "backlight" elsewhere in the tree.
>
> Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
> Cc: stable <stable@vger.kernel.org> # 3.7
> Cc: Matthias Kaehlcke <matthias@kaehlcke.net>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/video/backlight/tps65217_bl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread