From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFDCC433E0 for ; Mon, 3 Aug 2020 17:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D3D320678 for ; Mon, 3 Aug 2020 17:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbgHCRAd (ORCPT ); Mon, 3 Aug 2020 13:00:33 -0400 Received: from mga04.intel.com ([192.55.52.120]:41120 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727114AbgHCRAd (ORCPT ); Mon, 3 Aug 2020 13:00:33 -0400 IronPort-SDR: BwMCJFCVMZfUsOwnLPhW7oNYZuQqv502c+eg+MfmzgvWujGtZGolfAKC/WwGEmeECOdP8OfxAx /HF2z8Xi5+iA== X-IronPort-AV: E=McAfee;i="6000,8403,9702"; a="149597368" X-IronPort-AV: E=Sophos;i="5.75,430,1589266800"; d="scan'208";a="149597368" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2020 10:00:32 -0700 IronPort-SDR: TRwz/MhK6c+F5gRQxBebl4W57gBcg4ULjqLdp02Mvt7L5qhP+0h7R+BfWq0VOUvvuW52ZhKIH6 ilKTsZKDhU6A== X-IronPort-AV: E=Sophos;i="5.75,430,1589266800"; d="scan'208";a="330137073" Received: from dravoori-mobl.amr.corp.intel.com (HELO [10.212.46.95]) ([10.212.46.95]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2020 10:00:31 -0700 Subject: Re: [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers" To: Takashi Iwai Cc: Hui Wang , alsa-devel@alsa-project.org, stable@vger.kernel.org References: <20200803064638.6139-1-hui.wang@canonical.com> <0db4f5fe-7895-2d00-8ce3-96f1245000ab@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <6f583ccc-2251-384d-bc20-aa17c83a45b4@linux.intel.com> Date: Mon, 3 Aug 2020 12:00:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 8/3/20 11:36 AM, Takashi Iwai wrote: > On Mon, 03 Aug 2020 17:27:12 +0200, > Pierre-Louis Bossart wrote: >> >> >> >> On 8/3/20 1:46 AM, Hui Wang wrote: >>> This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow() >>> for all hda controllers"). >>> >>> The reverted patch already introduced some regressions on some >>> machines: >>> - on gemini-lake machines, the error of "azx_get_response timeout" >>> happens in the hda driver. >>> - on the machines with alc662 codec, the audio jack detection doesn't >>> work anymore. >>> >>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511 >>> Cc: >>> Signed-off-by: Hui Wang >>> --- >>> sound/pci/hda/hda_intel.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c >>> index e699873c8293..e34a4d5d047c 100644 >>> --- a/sound/pci/hda/hda_intel.c >>> +++ b/sound/pci/hda/hda_intel.c >>> @@ -2352,7 +2352,6 @@ static int azx_probe_continue(struct azx *chip) >>> if (azx_has_pm_runtime(chip)) { >>> pm_runtime_use_autosuspend(&pci->dev); >>> - pm_runtime_allow(&pci->dev); >>> pm_runtime_put_autosuspend(&pci->dev); >>> } >> >> Do I get this right that this permanently disables pm_runtime on all >> Intel HDaudio controllers? > > It just drops the unconditional enablement of runtime PM. > It can be enabled via sysfs, and that's the old default (let admin > enabling it via udev or whatever). Sorry I am confused now. Kai seemed to suggest in the Bugzilla comments that this would be temporary, until these problems with i915 and ALC662 get fixed?