From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:54110 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752849AbdGNDqI (ORCPT ); Thu, 13 Jul 2017 23:46:08 -0400 Subject: Re: [PATCH] thermal: qcom: tsens: fix crash due to incorrect __init To: Rob Clark , linux-arm-msm@vger.kernel.org References: <20170630204023.31712-1-robdclark@gmail.com> Cc: Bjorn Andersson , stable@vger.kernel.org From: Rajendra Nayak Message-ID: <6fa68569-0587-1af0-e47e-853013080712@codeaurora.org> Date: Fri, 14 Jul 2017 09:16:02 +0530 MIME-Version: 1.0 In-Reply-To: <20170630204023.31712-1-robdclark@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 07/01/2017 02:10 AM, Rob Clark wrote: > init_common() is called from probe, which can happen after the __init > section is already unloaded in the case of -EPROBE_DEFER. Causing a > later probe to attempt to branch to hyperspace. > > Cc: > Signed-off-by: Rob Clark Sorry, seem to have missed looking at this patch, Acked-by: Rajendra Nayak Rob, in case you plan to resend this with the Acks, can you please copy Eduardo Valentin he would be the one to pick this one up. > --- > drivers/thermal/qcom/tsens-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > index b1449ad..22ad37c 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -123,7 +123,7 @@ static const struct regmap_config tsens_config = { > .reg_stride = 4, > }; > > -int __init init_common(struct tsens_device *tmdev) > +int init_common(struct tsens_device *tmdev) > { > void __iomem *base; > > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation