From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Guan-Yu Lin <guanyulin@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
mathias.nyman@intel.com, stern@rowland.harvard.edu,
wesley.cheng@oss.qualcomm.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [RFC PATCH] usb: host: xhci-sideband: fix deadlock in unregister path
Date: Wed, 4 Feb 2026 11:53:26 +0200 [thread overview]
Message-ID: <6fbc7f6d-7799-47db-b1d6-730c9dea5b22@linux.intel.com> (raw)
In-Reply-To: <CAOuDEK3xzpY7Cr8JgactH=Sy=h7aTEgdTqUiuX8xh6gvUNR5uw@mail.gmail.com>
On 2/4/26 11:15, Guan-Yu Lin wrote:
> Regarding xhci_sideband_check():
> I have a concern regarding power management with the proposed check:
>
> if (xhci->devs[i] && xhci->devs[i]->sideband)
> return true;
>
> vdev->sideband is assigned during xhci_sideband_register(), which
> happens when the class driver probes (device connection), and it
> persists until disconnect. If we use this check, the xHCI controller
> will be prevented from PM suspending (system suspend) as long as the
> device is connected, even if it is idle (not playing audio).
> For mobile power optimization, we need to allow the controller to
> suspend when the sideband is registered but idle.
>
> Since we are proceeding with Option B, the class driver will be
> maintaining the udev->offload_usage count via usb_offload_get/put(). I
> propose we still rely on usb_offload_check() (or check offload_usage)
> within the xHCI sideband check. This ensures we only block or adjust
> the PM suspend flow only when there is active data transfer.
Sounds reasonable to me
Thanks
Mathias
prev parent reply other threads:[~2026-02-04 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 7:47 [RFC PATCH] usb: host: xhci-sideband: fix deadlock in unregister path Guan-Yu Lin
2026-01-31 12:15 ` Greg KH
2026-02-02 10:03 ` Guan-Yu Lin
2026-02-03 14:14 ` Mathias Nyman
2026-02-04 9:15 ` Guan-Yu Lin
2026-02-04 9:53 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fbc7f6d-7799-47db-b1d6-730c9dea5b22@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guanyulin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox