From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:38259 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbeB0Eih (ORCPT ); Mon, 26 Feb 2018 23:38:37 -0500 Received: by mail-wr0-f194.google.com with SMTP id n7so23450602wrn.5 for ; Mon, 26 Feb 2018 20:38:37 -0800 (PST) Subject: Re: Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree To: Mark Brown Cc: Pan Xiuli , alsa-devel@alsa-project.org, stable@vger.kernel.org References: <20180226183407.22335-1-k.marinushkin@gmail.com> <20180226194755.GC6681@sirena.org.uk> From: Kirill Marinushkin Message-ID: <6ff745dd-00a0-fbe6-5af8-23887d95f47b@gmail.com> Date: Tue, 27 Feb 2018 05:38:52 +0100 MIME-Version: 1.0 In-Reply-To: <20180226194755.GC6681@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: stable-owner@vger.kernel.org List-ID: On 02/26/18 20:47, Mark Brown wrote: > On Mon, Feb 26, 2018 at 07:34:07PM +0100, Kirill Marinushkin wrote: > >> 2. The suggested commit breaks the existing ASoC. >> The existing functionality already works with several existing ASoC by >> Intel. The suggested commit will break it for the following reason: >> The ALSA topology mechanism loads the binary topology file into ASoC. The >> suggested commit modifies the parser, but the binaries are already created for >> the existing functionality. As a result, all existing binaries will be parsed >> incorrectly. > Are there actual binaries using the existing code or is that just > theoretical? My impression was that this was fixing things for existing > binaries which were shipped for non-mainline kernels, is that not the > case? There is an actual conf, which can be converted into an actual binary: `alsa-lib/src/conf/topology/broadwell/broadwell.conf` Theoretically, there can be an unknown number of the binaries, not available publicly. Broadwell exists for a long time, and there is no way to be sure that all the theoretically existing binaries are modified together with this kernel patch.