From: Jens Axboe <axboe@kernel.dk>
To: Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, kernel-team@fb.com
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] blk-wbt: wake up all when we scale up, not down
Date: Thu, 11 Oct 2018 13:31:17 -0600 [thread overview]
Message-ID: <729350ca-183a-ad1f-9d4f-3e90913a40f8@kernel.dk> (raw)
In-Reply-To: <20181011192930.2844-1-josef@toxicpanda.com>
On 10/11/18 1:29 PM, Josef Bacik wrote:
> Tetsuo brought to my attention that I screwed up the scale_up/scale_down
> helpers when I factored out the rq-qos code. We need to wake up all the
> waiters when we add slots for requests to make, not when we shrink the
> slots. Otherwise we'll end up things waiting forever. This was a
> mistake and simply puts everything back the way it was.
I'll apply this for 4.19. I haven't hit this in testing, I'm guessing
the jitter when going up and down hides the issue.
--
Jens Axboe
prev parent reply other threads:[~2018-10-12 2:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:29 [PATCH] blk-wbt: wake up all when we scale up, not down Josef Bacik
2018-10-11 19:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=729350ca-183a-ad1f-9d4f-3e90913a40f8@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox