From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Chen Yu <yu.c.chen@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>, Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.9 4/4] thermal: intel_powerclamp: Use get_cpu() instead of smp_processor_id() to avoid crash
Date: Wed, 12 Oct 2022 20:06:01 -0700 [thread overview]
Message-ID: <731def9d99e6e199ed4b6e29119746121c41ca32.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0iHu3ZZuHeC7q6x4ZERaAu0pP2ubqzUv3v2upxLwOFXsg@mail.gmail.com>
On Wed, 2022-10-12 at 18:58 +0200, Rafael J. Wysocki wrote:
> On Tue, Oct 11, 2022 at 3:23 PM Chen Yu <yu.c.chen@intel.com> wrote:
> >
> > Hi Pavel,
> > On 2022-10-11 at 13:36:46 +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > > >
> > > > [ Upstream commit 68b99e94a4a2db6ba9b31fe0485e057b9354a640 ]
> > > >
> > > > When CPU 0 is offline and intel_powerclamp is used to inject
> > > > idle, it generates kernel BUG:
> > > >
> > > > BUG: using smp_processor_id() in preemptible [00000000] code:
> > > > bash/15687
> > > > caller is debug_smp_processor_id+0x17/0x20
> > > > CPU: 4 PID: 15687 Comm: bash Not tainted 5.19.0-rc7+ #57
> > > > Call Trace:
> > > > <TASK>
> > > > dump_stack_lvl+0x49/0x63
> > > > dump_stack+0x10/0x16
> > > > check_preemption_disabled+0xdd/0xe0
> > > > debug_smp_processor_id+0x17/0x20
> > > > powerclamp_set_cur_state+0x7f/0xf9 [intel_powerclamp]
> > > > ...
> > > > ...
> > > >
> > > > Here CPU 0 is the control CPU by default and changed to the
> > > > current CPU,
> > > > if CPU 0 offlined. This check has to be performed under
> > > > cpus_read_lock(),
> > > > hence the above warning.
> > > >
> > > > Use get_cpu() instead of smp_processor_id() to avoid this BUG.
> > >
> > > This has exactly the same problem as smp_processor_id(), you just
> > > worked around the warning. If it is okay that control_cpu
> > > contains
> > > stale value, could we have a comment explaining why?
> > >
> > May I know why does control_cpu have stale value? The control_cpu
> > is a random picked online CPU which will be used later to collect
> > statistics.
> > As long as the control_cpu is online, it is valid IMO.
>
> So this is confusing, because the code makes the impression that
> getting the number of the CPU running the code matters in some way,
> which isn't the case.
>
> Something like cpumask_first(cpu_online_mask) should work as well if
> I'm not mistaken and it would be less confusing to use this instead
> IMO.
That should work as we are under hotplug lock anyway here.
Thanks,
Srinivas
next prev parent reply other threads:[~2022-10-13 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 20:55 [PATCH AUTOSEL 4.9 1/4] ACPI: video: Add Toshiba Satellite/Portege Z830 quirk Sasha Levin
2022-10-09 20:55 ` [PATCH AUTOSEL 4.9 2/4] MIPS: BCM47XX: Cast memcmp() of function to (void *) Sasha Levin
2022-10-09 20:55 ` [PATCH AUTOSEL 4.9 3/4] powercap: intel_rapl: fix UBSAN shift-out-of-bounds issue Sasha Levin
2022-10-09 20:55 ` [PATCH AUTOSEL 4.9 4/4] thermal: intel_powerclamp: Use get_cpu() instead of smp_processor_id() to avoid crash Sasha Levin
2022-10-11 11:36 ` Pavel Machek
2022-10-11 13:22 ` Chen Yu
2022-10-12 5:33 ` srinivas pandruvada
2022-10-12 16:58 ` Rafael J. Wysocki
2022-10-13 3:06 ` srinivas pandruvada [this message]
2022-10-13 12:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=731def9d99e6e199ed4b6e29119746121c41ca32.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox