Re: [PATCH] USB: serial: option: add Telewell TW-3G HSPA+ device id

[Lars Melin <larsm17@gmail.com>]

On 2017-06-12 16:50, Bjørn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
> 
>> Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the
>> Longcheer vendor id.
>>
>> Reported-by: Teemu Likonen <tlikonen@iki.fi>
>> Cc: stable <stable@vger.kernel.org>
>> Signed-off-by: Johan Hovold <johan@kernel.org>
>> ---
>>   drivers/usb/serial/option.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> Teemu, would you be able to test this patch?
>>
>> Thanks,
>> Johan
>>
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index 3bf61acfc26b..b48f3557b2e4 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
>>   /* SpeedUp SU9800 usb 3g modem */
>>   #define SPEEDUP_PRODUCT_SU9800			0x9800
>>   
>> +/* Telewell */
>> +#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
>> +
>>   /* Haier products */
>>   #define HAIER_VENDOR_ID				0x201e
>>   #define HAIER_PRODUCT_CE81B			0x10f8
>> @@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
>>   	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
>>   	},
>>   	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
>> +	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
>>   	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
>>   	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
>>   	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
> 
> 
> I was looking at the Windows drivers on
> https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
> whiche have this among the serial stuff:
> 
> [QCOM]
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06
> 
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
> %qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
> 
> 
> It's not clear what type of driver the 'cmntnet.sys' installed by this
> is, but I wonder if it maybe is QMI based on the 'qc' prefix?
> 
> 
> And maybe we should add the remaining device IDs too?
> 
> 
> 
> Bjørn
> 

1c9e:9803 can be added, the other ones may be reserved id's for
products that never reached the market.

/Lars