From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B685C43219 for ; Thu, 2 May 2019 14:42:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19ABC2081C for ; Thu, 2 May 2019 14:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556808137; bh=zl3f1U1qdc5+UGyWIUNpw3Pep+eDR0yy7kgp5H5+0Yw=; h=From:To:Cc:Subject:Date:List-ID:From; b=jGZYop1SVNKNcys9Pzw+hjvTUK/sHWqxpM+JVACZt3oXtKEoUThj7OU276KbbVzVo DGw99dBKUC4L7e+Q6DF2t/c61w3JiAdMkGXcRdoF21jK5jlH+VtuVIpAVMLw+JXoAe arnYByHBDigX5V+HjUPT0sAwaptv2Cn8+3X8qcXg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726270AbfEBOmQ (ORCPT ); Thu, 2 May 2019 10:42:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:53548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbfEBOmQ (ORCPT ); Thu, 2 May 2019 10:42:16 -0400 Received: from localhost (c-67-180-165-146.hsd1.ca.comcast.net [67.180.165.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC50B20656; Thu, 2 May 2019 14:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556808135; bh=zl3f1U1qdc5+UGyWIUNpw3Pep+eDR0yy7kgp5H5+0Yw=; h=From:To:Cc:Subject:Date:From; b=l2xBFaFKiw471yvWye0sbMhxsqCsbECno6mwYPuqzPLooiFDPkn8wW2T1p2Hcwly6 q9eFuB67kier9E6fCp4kctoQ3/YKD8iZhhEtLYTADJ/e3VsHO4IfxjhU8ZjbszQVtB nOOaP1qG7q3J0ygghSMeHpsbBOcxEbEFxqha4ZLo= From: Andy Lutomirski To: Greg KH Cc: LKML , Andy Lutomirski , Sebastian Andrzej Siewior , Rik van Riel , "H. Peter Anvin" , "Jason A. Donenfeld" , Ard Biesheuvel , Dave Hansen , Ingo Molnar , Nicolai Stange , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Thomas Gleixner , x86@kernel.org, stable@vger.kernel.org Subject: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export Date: Thu, 2 May 2019 07:42:14 -0700 Message-Id: <761345df6285930339aced868ebf8ec459091383.1556807897.git.luto@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The FPU is not a super-Linuxy internal detail, so remove the _GPL from its export. Without something like this patch, it's impossible for even highly license-respecting non-GPL modules to use the FPU, which seems silly to me. After all, the FPU is a CPU feature, not really a kernel feature at all. Cc: Sebastian Andrzej Siewior Cc:: Borislav Petkov Cc: Rik van Riel Cc: "H. Peter Anvin" Cc: "Jason A. Donenfeld" Cc: Ard Biesheuvel Cc: Dave Hansen Cc: Ingo Molnar Cc: Nicolai Stange Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Thomas Gleixner Cc: x86@kernel.org Cc: stable@vger.kernel.org Fixes: 12209993e98c ("x86/fpu: Don't export __kernel_fpu_{begin,end}()") Signed-off-by: Andy Lutomirski --- This fixes a genuine annoyance for ZFS on Linux. Regardless of what one may think about the people who distribute ZFS on Linux *binaries*, as far as I know, the source and the users who build it themselves are entirely respectful of everyone's license. I have no problem with EXPORT_SYMBOL_GPL() in general, but let's please avoid using it for things that aren't fundamentally Linux internals. arch/x86/kernel/fpu/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c index 2e5003fef51a..8de5687a470d 100644 --- a/arch/x86/kernel/fpu/core.c +++ b/arch/x86/kernel/fpu/core.c @@ -127,14 +127,14 @@ void kernel_fpu_begin(void) preempt_disable(); __kernel_fpu_begin(); } -EXPORT_SYMBOL_GPL(kernel_fpu_begin); +EXPORT_SYMBOL(kernel_fpu_begin); void kernel_fpu_end(void) { __kernel_fpu_end(); preempt_enable(); } -EXPORT_SYMBOL_GPL(kernel_fpu_end); +EXPORT_SYMBOL(kernel_fpu_end); /* * Save the FPU state (mark it for reload if necessary): -- 2.21.0