From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Kenneth Feng" <kenneth.feng@amd.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Xinhui Pan" <Xinhui.Pan@amd.com>
Subject: Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()
Date: Tue, 15 Apr 2025 13:55:05 +0200 [thread overview]
Message-ID: <777983bf-08d2-4ccd-aa92-4791c8f9195d@web.de> (raw)
In-Reply-To: <20250415100813.3071-1-vulab@iscas.ac.cn>
> The return value of fiji_populate_smc_boot_level() is needs to be checked.
should?
> An error handling is also needed to phm_find_boot_level() to reset the
> boot level when the function fails. A proper implementation can be found
> in tonga_populate_smc_boot_level().
Can you propose in a nicer way to complete the error handling?
Regards,
Markus
next prev parent reply other threads:[~2025-04-15 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 10:08 [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level() Wentao Liang
2025-04-15 11:55 ` Markus Elfring [this message]
2025-04-16 23:03 ` Alex Deucher
2025-04-17 8:45 ` Feng, Kenneth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777983bf-08d2-4ccd-aa92-4791c8f9195d@web.de \
--to=markus.elfring@web.de \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kenneth.feng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox