From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F9315D5B7 for ; Wed, 28 Feb 2024 17:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709142390; cv=none; b=ewSR9cgIkr0sWiZuQmDB6l/6hbq2R6dFprXQn2dFFXcu3x/aVlAg9UBhtZR2f53ajDkouYJeJwc5vBiKjg2NnI3afSyMGTTH6FwShpIU8lnz/vifCMVSIlPvUEW496j3p1lUi3efJqhOUv6AQ0M8jJNal7urS788Cq7vVCzByw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709142390; c=relaxed/simple; bh=RNiAJSR8HzUP7osCHjX2jdlTzOLpWadd3gxK7DmUyjo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uEXvVHt5wosLzay7E6kLtprN6gsM8+wdOYr7PApWHyNv+mdlVoOrMC4VkrPO1AXUzVmNc1GeYBiO+jp+VVOi5ipIkaRcqLkDYkzDzwD8KzVr5kxFoc96+4tGOnrStXXor6n6EUeGUSqHqIYKDKYLGxEwMDOKtvNfNh5Hw384prc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MYwLr5qk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MYwLr5qk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20561C433F1; Wed, 28 Feb 2024 17:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709142390; bh=RNiAJSR8HzUP7osCHjX2jdlTzOLpWadd3gxK7DmUyjo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MYwLr5qkCh+sS8X0TUpfR2DEii7R+rTpaE7c5NkMOgg2zwJ1qLM6O24fn70R3Av8N JGxTg6w3gdLFN7GlLZ7HSnwKOgz8jf1B/yqdns9lCkW0E8Nju19v5YGYC/HVkGSgqA t2QCiyrKPOSWOvgGtxhcsYA26hbRJKZ79Lz+M6VTSKqeQb4P61BNzE8C+3eo3iru+l xz6ICHkJYrQGrwCxk5bWCgg3f0+dPuh/77I0oQhX03CMuNw4Dbu8rT41nhR8vayrPg /h9/wtfCBg2nWtKvyw9LvlImDvmFx13FbzKM8tD+jbpyW5ljUYOPGo0bo7bVCJIfbY QS1KU2dOHW0Ag== Message-ID: <783e0cc9-9d8e-40d2-a4d1-a2f5547a1035@kernel.org> Date: Wed, 28 Feb 2024 18:46:27 +0100 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: FAILED: patch "[PATCH] mptcp: fix duplicate subflow creation" failed to apply to 5.15-stable tree Content-Language: en-GB, fr-BE To: gregkh@linuxfoundation.org, pabeni@redhat.com, davem@davemloft.net, martineau@kernel.org Cc: stable@vger.kernel.org References: <2024022602-extended-buffer-5cf7@gregkh> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <2024022602-extended-buffer-5cf7@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Greg, On 26/02/2024 14:18, gregkh@linuxfoundation.org wrote: > > The patch below does not apply to the 5.15-stable tree. (...) > Possible dependencies: > > 045e9d812868 ("mptcp: fix duplicate subflow creation") > b9d69db87fb7 ("mptcp: let the in-kernel PM use mixed IPv4 and IPv6 addresses") > bedee0b56113 ("mptcp: address lookup improvements") > 4638de5aefe5 ("mptcp: handle local addrs announced by userspace PMs") > c682bf536cf4 ("mptcp: add pm_nl_pernet helpers") > 4cf86ae84c71 ("mptcp: strict local address ID selection") > d045b9eb95a9 ("mptcp: introduce implicit endpoints") > aaa25a2fa796 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") (...) > From 045e9d812868a2d80b7a57b224ce8009444b7bbc Mon Sep 17 00:00:00 2001 > From: Paolo Abeni > Date: Thu, 15 Feb 2024 19:25:33 +0100 > Subject: [PATCH] mptcp: fix duplicate subflow creation > > Fullmesh endpoints could end-up unexpectedly generating duplicate > subflows - same local and remote addresses - when multiple incoming > ADD_ADDR are processed before the PM creates the subflow for the local > endpoints. > > Address the issue explicitly checking for duplicates at subflow > creation time. > > To avoid a quadratic computational complexity, track the unavailable > remote address ids in a temporary bitmap and initialize such bitmap > with the remote ids of all the existing subflows matching the local > address currently processed. > > The above allows additionally replacing the existing code checking > for duplicate entry in the current set with a simple bit test > operation. FYI, because of the various conflicts, and because the issue is quite harmless -- duplicated subflows are created, but only when trying to create a high number of subflows, limited to 8 in v5.15, almost unnoticed bug so far --, I think it is better not to try to backport this patch to v5.15. Cheers, Matt -- Sponsored by the NGI0 Core fund.