From: LihaSika <lihasika@gmail.com>
To: stable@vger.kernel.org
Cc: regressions@lists.linux.dev
Subject: Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high
Date: Thu, 26 Oct 2023 18:32:02 +0300 [thread overview]
Message-ID: <7bfd4f9e-9f8d-4102-ab03-7d0401f00513@gmail.com> (raw)
Hi,
in kernel 6.1 (maybe 5.x - 6.x) there's an ATACB setting for "Super Top
USB 2.0 SATA Bridge" -devices, where the minimum bcdDevice version to
match has been set to 1.60. It's in the file
drivers/usb/storage/unusual_cypress.h:
"""
UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160,
"Super Top",
"USB 2.0 SATA BRIDGE",
USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
"""
My old USB HDD with a "Super Top" bridge has bcdDevice version 1.50,
thus the setting won't match and it will not mount.
I'm not sure when this changed (after kernel 4.x?), but it used to work
before. Reading some earlier bug reports, it seems that the max version
used to be 0x9999, which then caused corruption in "Super Top" devices
with version >=2.20. So that's a reason for lowering the maximum value,
but I wonder why the minimum value has also been set to 0x0160.
I created a patch, changing 0x0160 to 0x0150 (though I should've left
the max version as it was...):
"""
UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0150,
"""
Built, installed and rebooted; now the USB HDD can be mounted and works
perfectly again. I did some write & read tests, checked with diff, cmp
and md5sum - no corruption, everything OK 👍
Best regards,
LihaS
next reply other threads:[~2023-10-26 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:32 LihaSika [this message]
2023-10-26 19:14 ` Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfd4f9e-9f8d-4102-ab03-7d0401f00513@gmail.com \
--to=lihasika@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox