From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH for v4.9-stable] reset: make optional functions really optional To: Sasha Levin Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org, Philipp Zabel References: <20181203173029.18549-1-dinguyen@kernel.org> <20181203174422.GM235790@sasha-vm> From: Dinh Nguyen Message-ID: <7c56aa7e-f86c-e1d8-ad65-ca35c287ce75@kernel.org> Date: Mon, 3 Dec 2018 12:31:59 -0600 MIME-Version: 1.0 In-Reply-To: <20181203174422.GM235790@sasha-vm> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: On 12/3/18 11:44 AM, Sasha Levin wrote: > On Mon, Dec 03, 2018 at 11:30:29AM -0600, Dinh Nguyen wrote: >> From: Ramiro Oliveira >> >> commit bb475230b8e59a547ab66ac3b02572df21a580e9 upstream. >> >> The *_get_optional_* functions weren't really optional so this patch >> makes them really optional. >> >> These *_get_optional_* functions will now return NULL instead of an error >> if no matching reset phandle is found in the DT, and all the >> reset_control_* functions now accept NULL rstc pointers. >> >> Signed-off-by: Ramiro Oliveira >> Signed-off-by: Philipp Zabel >> --- >> Please apply to v4.9.y stable tree. > > The original commit had a few upstream fixes: > > bb6c7768385b reset: remove remaining WARN_ON() in > 1554bbd4ad40 reset: make device_reset_optional() really optional > 62e24c5775ec reset: add exported __reset_control_get, return NULL if > optional > 0ca10b60ceeb reset: fix optional reset_control_get stubs to return NULL > 4891486fb2c8 reset: core: fix reset_control_put > > We'll need to backport them to 4.9 as well if you backport this commit. > Hmm..I was able to fix an ethernet driver load issue by just backporting this patch. Should I investigate backport of the other patches as well? Dinh