From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Clayton Craft <clayton@craftyguy.net>
Subject: Re: [PATCH] soc: qcom: pmic_glink_altmode: fix spurious DP hotplug events
Date: Tue, 25 Mar 2025 12:29:37 +0100 [thread overview]
Message-ID: <7d74ef63-83fc-4c19-a247-d779cdd4e482@oss.qualcomm.com> (raw)
In-Reply-To: <Z-Jr7MifpkR8cL5B@hovoldconsulting.com>
On 3/25/25 9:40 AM, Johan Hovold wrote:
> On Mon, Mar 24, 2025 at 08:21:10PM +0100, Konrad Dybcio wrote:
>> On 3/24/25 2:24 PM, Johan Hovold wrote:
>>> The PMIC GLINK driver is currently generating DisplayPort hotplug
>>> notifications whenever something is connected to (or disconnected from)
>>> a port regardless of the type of notification sent by the firmware.
>>
>> Yikes!
>>
>> Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> That said, I'm hoping there isn't any sort of "port is full of water,
>> emergency" messages that we should treat as "unplug" though..
>
> Seems a bit far fetched, but I guess only you guys inside Qualcomm can
> try to figure that out.
I tried looking around, but couldn't find anything like that
> An alternative could be to cache the hpd_state regardless of the svid
> and only forward changes. But perhaps the hpd_state bit is only valid
> for DP notifications.
The current state of your patch seems to be a good approach, I think.
Konrad
next prev parent reply other threads:[~2025-03-25 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 13:24 [PATCH] soc: qcom: pmic_glink_altmode: fix spurious DP hotplug events Johan Hovold
2025-03-24 17:05 ` Clayton Craft
2025-03-25 8:32 ` Johan Hovold
2025-03-26 14:43 ` Johan Hovold
2025-04-01 18:18 ` Clayton Craft
2025-04-02 7:13 ` Johan Hovold
2025-03-24 19:21 ` Konrad Dybcio
2025-03-25 8:40 ` Johan Hovold
2025-03-25 11:29 ` Konrad Dybcio [this message]
2025-05-09 22:13 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d74ef63-83fc-4c19-a247-d779cdd4e482@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=clayton@craftyguy.net \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox