From: Florian Fainelli <f.fainelli@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
shuah@kernel.org, patches@kernelci.org,
lkft-triage@lists.linaro.org, pavel@denx.de,
jonathanh@nvidia.com, sudipm.mukherjee@gmail.com,
srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org,
allen.lkml@gmail.com,
Florian Fainelli <florian.fainelli@broadcom.com>,
Doug Berger <opendmb@gmail.com>
Subject: Re: [PATCH 6.1 000/243] 6.1.91-rc2 review
Date: Wed, 15 May 2024 10:00:25 -0700 [thread overview]
Message-ID: <7e82ae93-5067-4bcc-9a73-27820d8b3dca@gmail.com> (raw)
In-Reply-To: <823e7e2e-4536-428c-a029-8907ebf89635@roeck-us.net>
On 5/15/24 09:58, Guenter Roeck wrote:
> On 5/15/24 09:20, Linus Torvalds wrote:
>> On Wed, 15 May 2024 at 09:17, Mark Brown <broonie@kernel.org> wrote:
>>>
>>> A bisect claims that "net: bcmgenet:
>>> synchronize EXT_RGMII_OOB_CTRL access" is the first commit that breaks,
>>> I'm not seeing issues with other stables.
>>
>> That's d85cf67a3396 ("net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL
>> access") upstream. Is upstream ok?
>>
>
> Upstream code was rearranged. d85cf67a3396 affects bcmgenet_mii_config().
> 3443d6c3616b affects bcmgenet_mac_config(). bcmgenet_mac_config()
> is called from bcmgenet_phy_pause_set() under phydev->lock. I would guess
> that trying to acquire the same lock in in bcmgenet_mac_config() results
> in a deadlock.
Yes that's exactly what is happening:
https://lore.kernel.org/all/d52e7e4a-2b60-4fdf-9006-12528a91dabf@broadcom.com/
Thanks!
--
Florian
next prev parent reply other threads:[~2024-05-15 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 8:27 [PATCH 6.1 000/243] 6.1.91-rc2 review Greg Kroah-Hartman
2024-05-15 16:17 ` Mark Brown
2024-05-15 16:20 ` Linus Torvalds
2024-05-15 16:40 ` Florian Fainelli
2024-05-15 16:54 ` Florian Fainelli
2024-05-15 17:02 ` [PATCH stable 6.1 0/4] GENET stable patches for 6.1 Florian Fainelli
2024-05-15 17:02 ` [PATCH stable 6.1 1/4] net: bcmgenet: Clear RGMII_LINK upon link down Florian Fainelli
2024-05-15 17:02 ` [PATCH stable 6.1 2/4] net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access Florian Fainelli
2024-05-15 17:02 ` [PATCH stable 6.1 3/4] net: bcmgenet: synchronize use of bcmgenet_set_rx_mode() Florian Fainelli
2024-05-15 17:02 ` [PATCH stable 6.1 4/4] net: bcmgenet: synchronize UMAC_CMD access Florian Fainelli
2024-05-15 17:35 ` [PATCH stable 6.1 0/4] GENET stable patches for 6.1 Mark Brown
2024-05-16 9:11 ` Greg Kroah-Hartman
2024-05-15 16:42 ` [PATCH 6.1 000/243] 6.1.91-rc2 review Mark Brown
2024-05-15 16:58 ` Guenter Roeck
2024-05-15 17:00 ` Florian Fainelli [this message]
2024-05-15 16:48 ` Conor Dooley
2024-05-15 19:02 ` Ron Economos
2024-05-16 9:10 ` Yann Sionneau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e82ae93-5067-4bcc-9a73-27820d8b3dca@gmail.com \
--to=f.fainelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=broonie@kernel.org \
--cc=conor@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=opendmb@gmail.com \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=rwarsow@gmx.de \
--cc=shuah@kernel.org \
--cc=srw@sladewatkins.net \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox