From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89104C7EE23 for ; Wed, 31 May 2023 15:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbjEaP27 (ORCPT ); Wed, 31 May 2023 11:28:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234273AbjEaP25 (ORCPT ); Wed, 31 May 2023 11:28:57 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32B3186 for ; Wed, 31 May 2023 08:28:29 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-64d2a613ec4so4125463b3a.1 for ; Wed, 31 May 2023 08:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1685546909; x=1688138909; h=in-reply-to:from:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=oZX7ELhm3wgi7k38suP5hh33BBLXL9aFNM4ETTlxh5E=; b=FseECmWq859pk8lnEBRNokXfgWPCc0FHLrfJM/cNk1nIY5Yi/DMmOfk8OTS/kKZISd Wioxdi0XxYLsFGIBmBoS249BQJn9ISl+Vwbln1Cng6n9Ooe5bryb+Cln7n1uSZljL3Fc gfGcHQIDp7Tc3LhPPDmjqdrbsaUx/2ndr4W4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685546909; x=1688138909; h=in-reply-to:from:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oZX7ELhm3wgi7k38suP5hh33BBLXL9aFNM4ETTlxh5E=; b=J4bMZ1IqbM9kmpMMkgE+IQU1tfjr0KRmJN+aj3YfvITLNPyR7srw0WjkiyuaVE03U4 VBUgugwjrX+3xMdJPjuOZE3fbbB1AO3XnxlQ+KjubGucyRBW16oxknrvn0jvHkuUMuQ3 LlPar4VHwCv5/aY1/jdLS9IuE43q4a3rFNET1sasO+j9aytT/3vsOfq2ls9PT1G4+aGn sDeGd9hl27LS9FbDln+y0V1dzKYRPQr1imD+efwVH87LIBXYRUo0kuFoRQ2P02C2Xn8F 8T7GzpAWfeOV/Ds9IoZjgxQzAbTINgvPP5Ypn7Re29rHQn/3NRDNhnE7FWC3ZiPkRAc7 YQJQ== X-Gm-Message-State: AC+VfDx7BAz6XDT1vkBIy7AvAl7zi8g+3rNZtv4x/+86Ny51JJmhE+bp LVRNd7aJOggTekJL6ExEv3/2ag== X-Google-Smtp-Source: ACHHUZ4BLKIeFJvuKEGIyeNby4JnwkQ8StgeX8SKmHkaFDiF/mDL5vjp2KMekdAdqVrB/050Ui0K8A== X-Received: by 2002:a05:6a20:3c87:b0:10f:2abb:c9fd with SMTP id b7-20020a056a203c8700b0010f2abbc9fdmr5722993pzj.43.1685546909133; Wed, 31 May 2023 08:28:29 -0700 (PDT) Received: from [10.230.29.214] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id e13-20020aa7824d000000b0063f0ef3b421sm3628986pfn.14.2023.05.31.08.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 08:28:28 -0700 (PDT) Message-ID: <7eae52f6-ca7e-5017-629e-43761d4eb5d7@broadcom.com> Date: Wed, 31 May 2023 08:28:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH stable 6.3 v2] arch_topology: Remove early cacheinfo error message if -ENOENT To: Sudeep Holla Cc: Conor Dooley , stable@vger.kernel.org, Pierre Gondois , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , "open list:GENERIC ARCHITECTURE TOPOLOGY" References: <20230530201955.848176-1-florian.fainelli@broadcom.com> <20230530-basically-wildly-84415a94171d@spud> <72d84100-55cf-566d-8301-7147ce14b1e9@broadcom.com> <20230531085356.ru4fmtawyxo5cq5s@bogus> From: Florian Fainelli In-Reply-To: <20230531085356.ru4fmtawyxo5cq5s@bogus> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000cbc64a05fcfef8a3" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --000000000000cbc64a05fcfef8a3 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/31/2023 1:53 AM, Sudeep Holla wrote: > On Tue, May 30, 2023 at 03:42:45PM -0700, Florian Fainelli wrote: >> Hi Conor, >> >> On 5/30/23 14:39, Conor Dooley wrote: >>> Yo Florian, >>> >>> On Tue, May 30, 2023 at 01:19:55PM -0700, Florian Fainelli wrote: >>>> From: Pierre Gondois >>>> >>>> commit 3522340199cc060b70f0094e3039bdb43c3f6ee1 upstream >>>> >>>> fetch_cache_info() tries to get the number of cache leaves/levels >>>> for each CPU in order to pre-allocate memory for cacheinfo struct. >>>> Allocating this memory later triggers a: >>>> 'BUG: sleeping function called from invalid context' >>>> in PREEMPT_RT kernels. >>>> >>>> If there is no cache related information available in DT or ACPI, >>>> fetch_cache_info() fails and an error message is printed: >>>> 'Early cacheinfo failed, ret = ...' >>>> >>>> Not having cache information should be a valid configuration. >>>> Remove the error message if fetch_cache_info() fails with -ENOENT. >>>> >>>> Suggested-by: Conor Dooley >>>> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/ >>>> Signed-off-by: Pierre Gondois >>>> Reviewed-by: Conor Dooley >>>> Link: https://lore.kernel.org/r/20230414081453.244787-4-pierre.gondois@arm.com >>>> Signed-off-by: Sudeep Holla >>>> Signed-off-by: Florian Fainelli >>> >>> How come this now needs a backport? Did the rest of the series get >>> backported, but not this one since it has no fixes tag? >> >> Humm, indeed, this has been present in v6.3.2 since I requested it to be >> included. The error that I saw this morning was not -ENOENT, but -EINVAL. >> >> With those patches applied, no more -EINVAL: >> >> cacheinfo: Allow early level detection when DT/ACPI info is missing/broken >> cacheinfo: Add arm64 early level initializer implementation >> cacheinfo: Add arch specific early level initializer >> cacheinfo: Add use_arch[|_cache]_info field/function >> >> I will submit those shortly unless we think they better not be in 6.3, in >> which case it would be nice to silence those -EINVAL errors. > > I prefer this option instead of back porting all the above 4 as there are > some pending fixes for the issues found in those patches. I am fine if Greg > is happy with the backport, so no strong rejection from my side :). OK, so are you suggesting that we specific check for -EINVAL and -ENOENT rather than take all of the 4 above patches, if so, any preference on how to do it given the state of 6.3 stable? -- Florian --000000000000cbc64a05fcfef8a3 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQeQYJKoZIhvcNAQcCoIIQajCCEGYCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3QMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVgwggRAoAMCAQICDBP8P9hKRVySg3Qv5DANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAxMjE4MTFaFw0yNTA5MTAxMjE4MTFaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGTAXBgNVBAMTEEZsb3JpYW4gRmFpbmVsbGkxLDAqBgkqhkiG 9w0BCQEWHWZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEA+oi3jMmHltY4LMUy8Up5+1zjd1iSgUBXhwCJLj1GJQF+GwP8InemBbk5rjlC UwbQDeIlOfb8xGqHoQFGSW8p9V1XUw+cthISLkycex0AJ09ufePshLZygRLREU0H4ecNPMejxCte KdtB4COST4uhBkUCo9BSy1gkl8DJ8j/BQ1KNUx6oYe0CntRag+EnHv9TM9BeXBBLfmMRnWNhvOSk nSmRX0J3d9/G2A3FIC6WY2XnLW7eAZCQPa1Tz3n2B5BGOxwqhwKLGLNu2SRCPHwOdD6e0drURF7/ Vax85/EqkVnFNlfxtZhS0ugx5gn2pta7bTdBm1IG4TX+A3B1G57rVwIDAQABo4IB3jCCAdowDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAoBgNVHREEITAfgR1mbG9yaWFuLmZhaW5lbGxpQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggr BgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUUwwfJ6/F KL0fRdVROal/Lp4lAF0wDQYJKoZIhvcNAQELBQADggEBAKBgfteDc1mChZjKBY4xAplC6uXGyBrZ kNGap1mHJ+JngGzZCz+dDiHRQKGpXLxkHX0BvEDZLW6LGOJ83ImrW38YMOo3ZYnCYNHA9qDOakiw 2s1RH00JOkO5SkYdwCHj4DB9B7KEnLatJtD8MBorvt+QxTuSh4ze96Jz3kEIoHMvwGFkgObWblsc 3/YcLBmCgaWpZ3Ksev1vJPr5n8riG3/N4on8gO5qinmmr9Y7vGeuf5dmZrYMbnb+yCBalkUmZQwY NxADYvcRBA0ySL6sZpj8BIIhWiXiuusuBmt2Mak2eEv0xDbovE6Z6hYyl/ZnRadbgK/ClgbY3w+O AfUXEZ0xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52 LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwT /D/YSkVckoN0L+QwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIB1QJpUWuYqs5WuD 1n5N6UfJ8L0pzA3z/iiZYqYjg2j+MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTIzMDUzMTE1MjgyOVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZI AWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEH MAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQDhmDqlJwLZ23Xo9eNFytxjenu3fBriV+CC aNIVMLcUKgk8jJg7ysyMbFRneUyl/bTXf0stDjFec+Ap2jZSsnnkbgy5vboNXzanP8teGBQpDp8V gqMc3QnPeEIam5/nsQCDBISZGUBwSb78yM5UiddMULQ5/BKr3FqZHYOyAtgZn5Ok/mfGEHg2PEVQ zm5x0Ry7AvvCKJpBgU31KJoCtbEqAgMhGJeA03JBL5VW/jI8RLps2eju4SD5jq5yKdkW7A8NpoA0 +oDxIHMSva/y81hK3HTX+uzYUwbq4F3ZCdj1w7GjGIQxYJ0r/HSc785VFeY473m1zfEWWcWjo7YK NPnD --000000000000cbc64a05fcfef8a3--