public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>,
	stable@vger.kernel.org, "J. Kiszka" <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI
Date: Mon, 6 Jun 2016 10:10:12 +0200	[thread overview]
Message-ID: <7f0438c4-f293-7b3b-3ec1-ebe5d55a7f57@redhat.com> (raw)
In-Reply-To: <CANRm+CyfpvgSCKSArnRP0JPcMhQvo2kkgzZv7J4XL9vZFzRimQ@mail.gmail.com>



On 05/06/2016 05:28, Wanpeng Li wrote:
>> > No, I don't think so, the existing req_immediate_exit case is only after
>> > a VMLAUNCH/VMRESUME vmexit, in which case we already have a
>> >
>> >         if (vmx->nested.nested_run_pending)
>> >                 kvm_make_request(KVM_REQ_EVENT, vcpu);
>> >
>> > in vmx_vcpu_run.
> Do you think this can be removed since it blindly request a
> KVM_REQ_EVENT even if there is no still-pending event to L1 which
> blocked by nested_run_pending, however, req_immediate_exit can
> indicate there is a pending event blocked by nested_run_pending and
> the request KVM_REQUEST_EVENT added in your patch can guarantee inject
> this pending event in the next nested vmexit.

Yes, I think so.

Thanks,

Paolo

  reply	other threads:[~2016-06-06  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1464784501-13710-1-git-send-email-pbonzini@redhat.com>
2016-06-01 12:35 ` [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI Paolo Bonzini
2016-06-01 16:40   ` Radim Krčmář
2016-06-01 18:06     ` Paolo Bonzini
2016-06-05  3:28       ` Wanpeng Li
2016-06-06  8:10         ` Paolo Bonzini [this message]
2016-06-06  8:25           ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f0438c4-f293-7b3b-3ec1-ebe5d55a7f57@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox