From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:38152 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbeKHHCh (ORCPT ); Thu, 8 Nov 2018 02:02:37 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 07 Nov 2018 13:30:23 -0800 From: Rajkumar Manoharan To: Brian Norris Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Wang , Rakesh Pillai , Govind Singh , stable@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377" In-Reply-To: <20181107185643.240346-1-briannorris@chromium.org> References: <20181107185643.240346-1-briannorris@chromium.org> Message-ID: <7f2ef494f4a2aba1845a157da8fec449@codeaurora.org> Sender: stable-owner@vger.kernel.org List-ID: On 2018-11-07 10:56, Brian Norris wrote: > This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. > > WCN3990 firmware does not yet implement this feature, and so it crashes > like this: > > fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN > RT:207a:PC=b001b4f0 > > This feature can be re-implemented with a proper service bitmap or > other > feature-discovery mechanism in the future. But it should not break > working boards. > Brian, The change "ath10k: add quiet mode support for QCA6174/QCA9377" was merged even before full WCN3990 device support was added in ath10k. How come it could be regression for WCN3990. I know both are sharing same WMI-TLV interface but reverting this will break QCA6174/QCA9377. no? I would prefer to handle this within WMI callback or upper layer. -Rajkumar